From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id CDCA1385DC1C
 for <gdb-patches@sourceware.org>; Sat, 25 Apr 2020 05:59:57 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CDCA1385DC1C
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eliz@gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e]:49269)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1jSDr3-0006N8-A6; Sat, 25 Apr 2020 01:59:57 -0400
Received: from [176.228.60.248] (port=1552 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jSDr1-000364-FW; Sat, 25 Apr 2020 01:59:56 -0400
Date: Sat, 25 Apr 2020 08:59:45 +0300
Message-Id: <831roc9kby.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20200424203911.26599-1-tromey@adacore.com> (message from Tom
 Tromey on Fri, 24 Apr 2020 14:39:11 -0600)
Subject: Re: [PATCH] Expand dynamic type documentation
References: <20200424203911.26599-1-tromey@adacore.com>
X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Apr 2020 05:59:58 -0000

> From: Tom Tromey <tromey@adacore.com>
> Date: Fri, 24 Apr 2020 14:39:11 -0600
> Cc: Tom Tromey <tromey@adacore.com>
> 
> This expands the Python dynamic type documentation, as suggested by
> Christian.
> 
> gdb/doc/ChangeLog
> 2020-04-24  Tom Tromey  <tromey@adacore.com>
> 
> 	* python.texi (Types In Python): Mention missing fields.  Add
> 	dynamic type example.

Fine with me, with one minor comment:

> +Here, at least conceptually (whether your compiler actually does this
> +is a separate issue), examining @code{gdb.lookup_symbol("array", ...).type}

This long @code{..} expression is likely to be split between lines; to
prevent that, I suggest to wrap it in @w{..}.

Thanks.