NEWS entry for Changes to the "frame", "select-frame" ...

NEWS entry for Changes to the "frame", "select-frame" ...

[Philippe Waroquiers]

The below paragraph is at an unusual place in NEWS,
as new and changed commands are normally documented in the sections
  * New commands 
or
  * Changed commands.

Maybe it should be reworded and moved to these 2 sections ?

Philippe

* Changes to the "frame", "select-frame", and "info frame" CLI
  commands.  These commands all now take a frame specification which
  is either a frame level, or one of the keywords 'level', 'address',
  'function', or 'view' followed by a parameter.  Selecting a frame by
  address, or viewing a frame outside the current backtrace now
  requires the use of a keyword.  Selecting a frame by level is
  unchanged.  The MI comment "-stack-select-frame" is unchanged.

Re: NEWS entry for Changes to the "frame", "select-frame" ...

[Andrew Burgess]

* Philippe Waroquiers <philippe.waroquiers@skynet.be> [2019-01-04 21:34:31 +0100]:

> The below paragraph is at an unusual place in NEWS,
> as new and changed commands are normally documented in the sections
>   * New commands 
> or
>   * Changed commands.
> 
> Maybe it should be reworded and moved to these 2 sections ?
> 
> Philippe
> 
> * Changes to the "frame", "select-frame", and "info frame" CLI
>   commands.  These commands all now take a frame specification which
>   is either a frame level, or one of the keywords 'level', 'address',
>   'function', or 'view' followed by a parameter.  Selecting a frame by
>   address, or viewing a frame outside the current backtrace now
>   requires the use of a keyword.  Selecting a frame by level is
>   unchanged.  The MI comment "-stack-select-frame" is unchanged.

This is fine with me (as the original author), but you'll need a
maintainer to OK the change too.

Thanks,
Andrew

Re: NEWS entry for Changes to the "frame", "select-frame" ...

[Eli Zaretskii]

> Date: Sun, 6 Jan 2019 10:46:36 +0000
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: gdb-patches <gdb-patches@sourceware.org>
> 
> * Philippe Waroquiers <philippe.waroquiers@skynet.be> [2019-01-04 21:34:31 +0100]:
> 
> > The below paragraph is at an unusual place in NEWS,
> > as new and changed commands are normally documented in the sections
> >   * New commands 
> > or
> >   * Changed commands.
> > 
> > Maybe it should be reworded and moved to these 2 sections ?
> > 
> > Philippe
> > 
> > * Changes to the "frame", "select-frame", and "info frame" CLI
> >   commands.  These commands all now take a frame specification which
> >   is either a frame level, or one of the keywords 'level', 'address',
> >   'function', or 'view' followed by a parameter.  Selecting a frame by
> >   address, or viewing a frame outside the current backtrace now
> >   requires the use of a keyword.  Selecting a frame by level is
> >   unchanged.  The MI comment "-stack-select-frame" is unchanged.
> 
> This is fine with me (as the original author), but you'll need a
> maintainer to OK the change too.

I'm OK with moving this to the "Changed commands" section.

Thanks.

Re: NEWS entry for Changes to the "frame", "select-frame" ...

[Philippe Waroquiers]

On Sun, 2019-01-06 at 17:28 +0200, Eli Zaretskii wrote:
> > Date: Sun, 6 Jan 2019 10:46:36 +0000
> > From: Andrew Burgess <andrew.burgess@embecosm.com>
> > Cc: gdb-patches <gdb-patches@sourceware.org>
> > 
> > * Philippe Waroquiers <philippe.waroquiers@skynet.be> [2019-01-04 21:34:31 +0100]:
> > 
> > > The below paragraph is at an unusual place in NEWS,
> > > as new and changed commands are normally documented in the sections
> > >   * New commands 
> > > or
> > >   * Changed commands.
> > > 
> > > Maybe it should be reworded and moved to these 2 sections ?
> > > 
> > > Philippe
> > > 
> > > * Changes to the "frame", "select-frame", and "info frame" CLI
> > >   commands.  These commands all now take a frame specification which
> > >   is either a frame level, or one of the keywords 'level', 'address',
> > >   'function', or 'view' followed by a parameter.  Selecting a frame by
> > >   address, or viewing a frame outside the current backtrace now
> > >   requires the use of a keyword.  Selecting a frame by level is
> > >   unchanged.  The MI comment "-stack-select-frame" is unchanged.
> > 
> > This is fine with me (as the original author), but you'll need a
> > maintainer to OK the change too.
> 
> I'm OK with moving this to the "Changed commands" section.
> 
> Thanks.
Thanks for the feedback.
I pushed the below change.

Philippe

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1c20afc8a8..2e9c2f2e5a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
+
+       * NEWS: Move the description of the changed "frame", "select-frame",
+        and "info frame" commands to the Changed commands section.
+
 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 
        * gdbtypes.c (check_stub_method_group): Remove handling of old
diff --git a/gdb/NEWS b/gdb/NEWS
index 14c859f8f6..eaef6aa384 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -30,14 +30,6 @@
 * GDB in batch mode now exits with status 1 if the last command to be
   executed failed.
 
-* Changes to the "frame", "select-frame", and "info frame" CLI
-  commands.  These commands all now take a frame specification which
-  is either a frame level, or one of the keywords 'level', 'address',
-  'function', or 'view' followed by a parameter.  Selecting a frame by
-  address, or viewing a frame outside the current backtrace now
-  requires the use of a keyword.  Selecting a frame by level is
-  unchanged.  The MI comment "-stack-select-frame" is unchanged.
-
 * The RISC-V target now supports target descriptions.
 
 * System call catchpoints now support system call aliases on FreeBSD.
@@ -106,6 +98,14 @@ info proc files
 
 * Changed commands
 
+Changes to the "frame", "select-frame", and "info frame" CLI commands.
+  These commands all now take a frame specification which
+  is either a frame level, or one of the keywords 'level', 'address',
+  'function', or 'view' followed by a parameter.  Selecting a frame by
+  address, or viewing a frame outside the current backtrace now
+  requires the use of a keyword.  Selecting a frame by level is
+  unchanged.  The MI comment "-stack-select-frame" is unchanged.
+
 target remote FILENAME
 target extended-remote FILENAME
   If FILENAME is a Unix domain socket, GDB will attempt to connect