From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88242 invoked by alias); 14 Jun 2017 02:29:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88223 invoked by uid 89); 14 Jun 2017 02:29:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Jun 2017 02:29:27 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKy3i-0005MB-RG for gdb-patches@sourceware.org; Tue, 13 Jun 2017 22:29:29 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKy3i-0005M7-Nh; Tue, 13 Jun 2017 22:29:26 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1451 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dKy3h-00086s-Qz; Tue, 13 Jun 2017 22:29:26 -0400 Date: Wed, 14 Jun 2017 02:29:00 -0000 Message-Id: <831sqn4801.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: qiyaoltc@gmail.com, gdb-patches@sourceware.org In-reply-to: <5c75dd67a82d99cfe0befdfe777abcc9@polymtl.ca> (message from Simon Marchi on Tue, 13 Jun 2017 22:17:15 +0200) Subject: Re: [PATCH 0/5] Remove a few hurdles of compiling with clang Reply-to: Eli Zaretskii References: <1497124689-11842-1-git-send-email-simon.marchi@ericsson.com> <83tw3n5jyk.fsf@gnu.org> <86tw3labb0.fsf@gmail.com> <83a85d5l4n.fsf@gnu.org> <93eb64489ac9d53665a144ddf5a966d5@polymtl.ca> <83wp8h40lo.fsf@gnu.org> <8660g0dzau.fsf@gmail.com> <83k24g3qcx.fsf@gnu.org> <83a85b4rrs.fsf@gnu.org> <5c75dd67a82d99cfe0befdfe777abcc9@polymtl.ca> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00413.txt.bz2 > Date: Tue, 13 Jun 2017 22:17:15 +0200 > From: Simon Marchi > Cc: qiyaoltc@gmail.com, gdb-patches@sourceware.org > > On 2017-06-13 21:22, Eli Zaretskii wrote: > > See, I don't consider the proposed solution to be elegant, because it > > tweaks a perfectly valid code to placate a stupid compiler warning. > > It replaces perfectly valid code with some other perfectly valid code. Which is not used anywhere else, right? > We can always add comments like > > /* Don't use ALL_DEBUG_ADDRESS_REGISTERS here to silence Clang's > -Wfor-loop-analysis warning. */ That's the least we should do, IMO. Thanks.