From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25360 invoked by alias); 19 Oct 2016 06:29:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25345 invoked by uid 89); 19 Oct 2016 06:29:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1264 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Oct 2016 06:29:35 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwkNU-0005oj-Tg for gdb-patches@sourceware.org; Wed, 19 Oct 2016 02:29:33 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwkNU-0005of-Qf; Wed, 19 Oct 2016 02:29:28 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2339 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bwkNU-0003II-0s; Wed, 19 Oct 2016 02:29:28 -0400 Date: Wed, 19 Oct 2016 06:29:00 -0000 Message-Id: <831szcx35z.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: gdb-patches@sourceware.org In-reply-to: <1476839539-8374-32-git-send-email-palves@redhat.com> (message from Pedro Alves on Wed, 19 Oct 2016 02:12:19 +0100) Subject: Re: [PATCH v2 31/31] Support an "unlimited" number of user-defined arguments Reply-to: Eli Zaretskii References: <1476839539-8374-1-git-send-email-palves@redhat.com> <1476839539-8374-32-git-send-email-palves@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00558.txt.bz2 > From: Pedro Alves > Date: Wed, 19 Oct 2016 02:12:19 +0100 > > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > > * NEWS: Mention that user commands now accept an unlimited number > of arguments. > * cli/cli-script.c: Include . > (struct string_view): New type. > (MAXUSERARGS): Delete. > (struct user_args): Now a C++ class. > (user_args_stack): New. > (struct scoped_user_args_level): New type. > (execute_user_command): Use scoped_user_args_level. Adjust to > call insert_user_args instead of insert_args. > (arg_cleanup): Delete. > (setup_user_args): Deleted, and refactored as ... > (user_args::user_args): ... this new constructor. Limit of number > of arguments removed. > (insert_args): Delete. > (insert_user_args) New. > (user_args::insert_args): New, bits based on old insert_args with > limit of number of arguments eliminated. > * common/common-utils.h: Include . > (gdb::to_string): New. > > gdb/doc/ChangeLog: > yyyy-mm-dd Pedro Alves > > * gdb.texinfo (User-defined Commands): Limit on number of > arguments passed to user-defined commands removed; update. OK for the documentation parts. Thanks.