From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66732 invoked by alias); 9 Feb 2016 17:29:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66604 invoked by uid 89); 9 Feb 2016 17:29:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Received-From:4830, HX-Received-From:134, HX-Received-From:2001, HX-HELO:eggs.gnu.org X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 09 Feb 2016 17:29:35 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTC6S-0004jH-2d for gdb-patches@sourceware.org; Tue, 09 Feb 2016 12:29:33 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44873) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTC6R-0004jA-VR; Tue, 09 Feb 2016 12:29:28 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1265 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aTC6G-0006Ps-GE; Tue, 09 Feb 2016 12:29:27 -0500 Date: Tue, 09 Feb 2016 17:29:00 -0000 Message-Id: <831t8ldc80.fsf@gnu.org> From: Eli Zaretskii To: Tsutomu Seki CC: gdb-patches@sourceware.org In-reply-to: (message from Tsutomu Seki on Tue, 9 Feb 2016 22:49:57 +0900) Subject: Re: [PATCH] supports IPv6 only remote target Reply-to: Eli Zaretskii References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00242.txt.bz2 > Date: Tue, 9 Feb 2016 22:49:57 +0900 > From: Tsutomu Seki > > +Numerical @acronym{IPv6} address must be enclosed in square brackets. > +For example, to connect to port 2159 of a target which has IPv6 > +link-local address fe80::1 on eth1: Please use @code with the address string fe80::1. > + > +@smallexample > +target remote [fe80::1%eth1]:2159 > +@end smallexample This example seems to imply that more than just taking brackets is required. Should we tell more about that? > +The service name is default to ``gdbremote''. If the service name is Please use The service name defaults to @code{"gdbremote"} Also, we leave 2 spaces between sentences. > +present in service list (e.g.@: @file{/etc/services} on @sc{gnu}/Linux > +systems), and target is listening on assigned port, you can omit the I guess you mean "on the port assigned to that service", yes? The documentation parts are OK with these fixed. > --- a/gdb/ser-tcp.c > +++ b/gdb/ser-tcp.c > @@ -39,6 +39,7 @@ > > #ifdef USE_WIN32API > #include > +#include I think this will break the build with mingw.org's MinGW. It doesn't have wspiapi.h, AFAIK. What exactly is needed from that header? Thanks.