From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-120796-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 90569 invoked by alias); 16 Mar 2015 16:30:45 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 90458 invoked by uid 89); 16 Mar 2015 16:30:45 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout21.012.net.il
Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Mar 2015 16:30:43 +0000
Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NLB00700C8AXQ00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Mon, 16 Mar 2015 18:30:40 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NLB007M9CJ3UV90@a-mtaout21.012.net.il>; Mon, 16 Mar 2015 18:30:40 +0200 (IST)
Date: Mon, 16 Mar 2015 16:30:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] Find debug symbols file by buildid for coff file format also
In-reply-to: <1426520230-18940-1-git-send-email-jon.turney@dronecode.org.uk>
To: Jon TURNEY <jon.turney@dronecode.org.uk>
Cc: gdb-patches@sourceware.org, jon.turney@dronecode.org.uk
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <831tko29ct.fsf@gnu.org>
References: <1426520230-18940-1-git-send-email-jon.turney@dronecode.org.uk>
X-IsSubscribed: yes
X-SW-Source: 2015-03/txt/msg00460.txt.bz2

> From: Jon TURNEY <jon.turney@dronecode.org.uk>
> Cc: Jon TURNEY <jon.turney@dronecode.org.uk>
> Date: Mon, 16 Mar 2015 15:37:10 +0000
> 
> bfd/ChangeLog:
> 
> 2015-03-14  Jon TURNEY  <jon.turney@dronecode.org.uk>
> 
> 	* elf-bfd.h : Remove struct elf_build_id.
> 	* bfd.c : Add struct bfd_build_id.
> 	* bfd-in2.h: Regenerate.
> 	* elf.c (elfobj_grok_gnu_build_id): Update to use bfd_build_id.
> 	* libpei.h: Add protoype and macros for
> 	bfd_XXi_slurp_codeview_record.
> 	* peXXigen.c (_bfd_XXi_slurp_codeview_record): Make public
> 	* peicode.h (pe_bfd_read_buildid): Add.
> 	(pe_bfd_object_p): Use pe_bfd_read_buildid().
> 
> gdb/ChangeLog:
> 
> 2015-03-14  Jon TURNEY  <jon.turney@dronecode.org.uk>
> 
> 	* build-id.c (build_id_bfd_get): Use bfd_build_id.
> 	(build_id_verify): Ditto.
> 	* build-id.h: Ditto.
> 	(find_separate_debug_file_by_buildid): Ditto.
> 	* python/py-objfile.c (objfpy_get_build_id)
> 	(objfpy_build_id_matches, objfpy_lookup_objfile_by_build_id): Ditto.
> 	* coffread.c (coff_symfile_read): Try
> 	find_separate_debug_file_by_buildid.
> 
> gdb/doc/ChangeLog:
> 
> 2015-03-14  Jon TURNEY  <jon.turney@dronecode.org.uk>
> 
> 	* gdb.texinfo (Separate Debug Files): Document that COFF is also
> 	supported.

The gdb.texinfo part is OK, except that AFAIK PE is not the same as
COFF, so I suggest to amend the ChangeLog entry above.

Thanks.