From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-87066-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17964 invoked by alias); 13 Jan 2012 08:08:19 -0000
Received: (qmail 17952 invoked by uid 22791); 13 Jan 2012 08:08:15 -0000
X-SWARE-Spam-Status: No, hits=-1.3 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Jan 2012 08:08:02 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LXQ0080096E6200@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 13 Jan 2012 10:07:59 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.124.136.230]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LXQ007HS99AX150@a-mtaout22.012.net.il>; Fri, 13 Jan 2012 10:07:59 +0200 (IST)
Date: Fri, 13 Jan 2012 09:05:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [doc patch] gdbint: braces for two lines in code  [Re: [patch] Fix for PR gdb/9538 (loading of separate debuginfo and symlinks).]
In-reply-to: <20120112235451.GA14124@host2.jankratochvil.net>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: dje@google.com, ppluzhnikov@google.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <831ur4kot7.fsf@gnu.org>
References: <20120112030648.14DBE190AFD@elbrus2.mtv.corp.google.com> <CADPb22TZqh1KJv0KXxRNuhV8PZH-Z31CcggzJMBDJYo3OuZKdA@mail.gmail.com> <CALoOobMVWJB=u6Y8OMyNeva1KcgU7FP8FpR2aFQ4b2e+=QUgOQ@mail.gmail.com> <20120112212959.GA24491@host2.jankratochvil.net> <CALoOobOBfT4n5zXp-=4qyS_7+c0hkhWwxop9B=5aAHuti+bAWg@mail.gmail.com> <CADPb22Q9qi3TsYw3ZFkAyuO6a0VEJ_wtM_4pe_tXzDW5myi29Q@mail.gmail.com> <20120112232521.GA25432@host2.jankratochvil.net> <CADPb22TJhVz=jwsQzEMC=9Jf+df4qXJJkzwN=PkX=fOK2=Lsfg@mail.gmail.com> <20120112235451.GA14124@host2.jankratochvil.net>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-01/txt/msg00463.txt.bz2

> Date: Fri, 13 Jan 2012 00:54:51 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: Paul Pluzhnikov <ppluzhnikov@google.com>, gdb-patches@sourceware.org
> 
> On Fri, 13 Jan 2012 00:28:35 +0100, Doug Evans wrote:
> > I think we should make the braces required.
> 
> OK to check in?

Yes, with one comment:

> +Any two lines in code should be wrapped in braces as they look as separate
> +statements:
> +
> +@smallexample
> +if (i)
> +  @{
> +    /* Return success.  */
> +    return 0;
> +  @}
> +@end smallexample

If you really want to make a point that this rule is valid even if the
second line is a comment, then I suggest to say so explicitly in the
text.

Otherwise, I'd suggest to replace the comment with a non-comment line.

Thanks.