From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72150-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28600 invoked by alias); 15 Apr 2010 17:08:56 -0000
Received: (qmail 28533 invoked by uid 22791); 15 Apr 2010 17:08:53 -0000
X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 	tests=BAYES_00,SPF_SOFTFAIL,TW_OV
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Apr 2010 17:08:44 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0L0X00100GVGJW00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Thu, 15 Apr 2010 20:08:26 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([77.127.69.249]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L0X00FEVGY1BQR0@a-mtaout20.012.net.il>; Thu, 15 Apr 2010 20:08:26 +0300 (IDT)
Date: Thu, 15 Apr 2010 17:08:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] disassemble support start,+length format
In-reply-to: <1271317836-12963-1-git-send-email-crquan@gmail.com>
To: crquan@gmail.com
Cc: gdb-patches@sourceware.org, tromey@redhat.com, teawater@gmail.com, brobecker@adacore.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <831vegy779.fsf@gnu.org>
References: <1270739689-28732-1-git-send-email-crquan@gmail.com> <1271317836-12963-1-git-send-email-crquan@gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00469.txt.bz2

> From: crquan@gmail.com
> Cc: Hui Zhu <teawater@gmail.com>,
> 	Joel Brobecker <brobecker@adacore.com>,
> 	Eli Zaretskii <eliz@gnu.org>
> Date: Thu, 15 Apr 2010 15:50:36 +0800
> 
> add new support for disassemble by "start,+length" format;
> 
> update ChangeLog,NEWS,doc/gdb.texinfo accordingly.
> BTW, I found two disassemble Changes in GDB 7.0 in NEWS, separated in two
> paragraphs, so I merged them into one.

Thanks.

>  gdb-7.1.50.20100415/gdb/ChangeLog       |    8 +++++++-
>  gdb-7.1.50.20100415/gdb/NEWS            |   13 ++++++++-----
>  gdb-7.1.50.20100415/gdb/cli/cli-cmds.c  |   18 +++++++++++++++---
>  gdb-7.1.50.20100415/gdb/doc/gdb.texinfo |   28 ++++++++++++++++++++++++++--
>  4 files changed, 56 insertions(+), 11 deletions(-)

Please also add an entry in gdb/doc/ChangeLog regarding the changes in
gdb/doc/gdb.texinfo.

> +@smallexample
> +(gdb) disas /r main,+20
> +Dump of assembler code from 0x450670 to 0x450684:
> +   0x0000000000450670 <main+0>:	 48 83 ec 28	sub    $0x28,%rsp
> +   0x0000000000450674 <main+4>:	 48 c7 04 24 00 00 00 00	movq   $0x0,(%rsp)
> +   0x000000000045067c <main+12>:	 89 3c 24	mov    %edi,(%rsp)
> +   0x000000000045067f <main+15>:	 48 89 e7	mov    %rsp,%rdi
> +   0x0000000000450682 <main+18>:	 48 c7 44 24 10 00 00 00 00	movq   $0x0,0x10(%rsp)
> +End of assembler dump.
> +@end smallexample

This is okay, but any line inside @smallexample block that is longer
than 72 characters will overflow the page margins in the printed
version of the manual.  So could you perhaps select an example with
shorter lines?

Okay with that change.