From: Luis Machado <luis.machado@arm.com>
To: Thiago Jung Bauermann <thiago.bauermann@linaro.org>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v2 5/6] gdb/aarch64: Factor out most of the thread_architecture method
Date: Mon, 28 Nov 2022 12:09:09 +0000 [thread overview]
Message-ID: <832ac76f-4cc1-1ab4-a80c-f4d92005ea7e@arm.com> (raw)
In-Reply-To: <20221126020452.1686509-6-thiago.bauermann@linaro.org>
On 11/26/22 02:04, Thiago Jung Bauermann wrote:
> The same logic will be used by a subsequent commit when remotely debugging
> an aarch64-linux target.
>
> The code isn't changed, just moved around.
> ---
> gdb/aarch64-linux-nat.c | 28 ++--------------------------
> gdb/aarch64-tdep.c | 35 +++++++++++++++++++++++++++++++++++
> gdb/aarch64-tdep.h | 2 ++
> 3 files changed, 39 insertions(+), 26 deletions(-)
>
> diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
> index caefcb364852..ca230ea4fdb0 100644
> --- a/gdb/aarch64-linux-nat.c
> +++ b/gdb/aarch64-linux-nat.c
> @@ -884,33 +884,9 @@ aarch64_linux_nat_target::thread_architecture (ptid_t ptid)
> /* Find the current gdbarch the same way as process_stratum_target. */
> inferior *inf = find_inferior_ptid (this, ptid);
> gdb_assert (inf != NULL);
> -
> - /* If this is a 32-bit architecture, then this is ARM, not AArch64.
> - There's no SVE vectors here, so just return the inferior
> - architecture. */
> - if (gdbarch_bfd_arch_info (inf->gdbarch)->bits_per_word == 32)
> - return inf->gdbarch;
> -
> - /* Only return it if the current vector length matches the one in the tdep. */
> - aarch64_gdbarch_tdep *tdep
> - = gdbarch_tdep<aarch64_gdbarch_tdep> (inf->gdbarch);
> uint64_t vq = aarch64_sve_get_vq (ptid.lwp ());
> - if (vq == tdep->vq)
> - return inf->gdbarch;
> -
> - /* We reach here if the vector length for the thread is different from its
> - value at process start. Lookup gdbarch via info (potentially creating a
> - new one) by using a target description that corresponds to the new vq value
> - and the current architecture features. */
> -
> - const struct target_desc *tdesc = gdbarch_target_desc (inf->gdbarch);
> - aarch64_features features = aarch64_features_from_target_desc (tdesc);
> - features.vq = vq;
> -
> - struct gdbarch_info info;
> - info.bfd_arch_info = bfd_lookup_arch (bfd_arch_aarch64, bfd_mach_aarch64);
> - info.target_desc = aarch64_read_description (features);
> - return gdbarch_find_by_info (info);
> +
> + return aarch64_update_gdbarch (inf->gdbarch, vq);
> }
>
> /* Implement the "supports_memory_tagging" target_ops method. */
> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
> index 07330356fdcb..ffc128d91f60 100644
> --- a/gdb/aarch64-tdep.c
> +++ b/gdb/aarch64-tdep.c
> @@ -3486,6 +3486,41 @@ aarch64_cannot_store_register (struct gdbarch *gdbarch, int regnum)
> || regnum == AARCH64_PAUTH_CMASK_REGNUM (tdep->pauth_reg_base));
> }
>
> +/* Helper function for the "thread_architecture" target_ops method.
> +
> + Returns a new gdbarch that is equivalent to the given gdbarch, but with SVE
> + registers reflecting the given vq value. */
> +
> +struct gdbarch *
> +aarch64_update_gdbarch (struct gdbarch *gdbarch, uint64_t vq)
> +{
> + /* If this is a 32-bit architecture, then this is ARM, not AArch64.
> + There's no SVE vectors here, so just return the inferior
> + architecture. */
> + if (gdbarch_bfd_arch_info (gdbarch)->bits_per_word == 32)
> + return gdbarch;
> +
> + /* Only return it if the current vector length matches the one in the
> + tdep. */
> + aarch64_gdbarch_tdep *tdep = gdbarch_tdep<aarch64_gdbarch_tdep> (gdbarch);
> + if (vq == tdep->vq)
> + return gdbarch;
> +
> + /* We reach here if the vector length for the thread is different from its
> + value at process start. Lookup gdbarch via info (potentially creating a
> + new one) by using a target description that corresponds to the new vq value
> + and the current architecture features. */
> +
> + const struct target_desc *tdesc = gdbarch_target_desc (gdbarch);
> + aarch64_features features = aarch64_features_from_target_desc (tdesc);
> + features.vq = vq;
> +
> + struct gdbarch_info info;
> + info.bfd_arch_info = bfd_lookup_arch (bfd_arch_aarch64, bfd_mach_aarch64);
> + info.target_desc = aarch64_read_description (features);
> + return gdbarch_find_by_info (info);
> +}
> +
> /* Implement the stack_frame_destroyed_p gdbarch method. */
>
> static int
> diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
> index 55ccf2e777d2..80b9b3281a2d 100644
> --- a/gdb/aarch64-tdep.h
> +++ b/gdb/aarch64-tdep.h
> @@ -143,4 +143,6 @@ void aarch64_displaced_step_fixup (struct gdbarch *gdbarch,
>
> bool aarch64_displaced_step_hw_singlestep (struct gdbarch *gdbarch);
>
> +struct gdbarch *aarch64_update_gdbarch (struct gdbarch *gdbarch, uint64_t vq);
> +
> #endif /* aarch64-tdep.h */
LGTM.
Approved-by: Luis Machado <luis.machado@arm.com>
next prev parent reply other threads:[~2022-11-28 12:09 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-26 2:04 [PATCH v2 0/6] gdbserver improvements for AArch64 SVE support Thiago Jung Bauermann
2022-11-26 2:04 ` [PATCH v2 1/6] gdbserver: Add asserts in register_size and register_data functions Thiago Jung Bauermann
2022-11-28 11:51 ` Luis Machado
2022-11-29 2:53 ` Thiago Jung Bauermann
2022-11-28 14:48 ` Simon Marchi
2022-11-28 14:53 ` Simon Marchi
2022-11-29 2:52 ` Thiago Jung Bauermann
2022-11-29 2:43 ` Thiago Jung Bauermann
2022-11-26 2:04 ` [PATCH v2 2/6] gdbserver: Add PID parameter to linux_get_auxv and linux_get_hwcap Thiago Jung Bauermann
2022-11-28 11:50 ` Luis Machado
2022-11-28 15:01 ` Simon Marchi
2022-11-29 3:10 ` Thiago Jung Bauermann
2022-11-28 15:07 ` Simon Marchi
2022-11-28 15:20 ` Luis Machado
2022-11-29 3:17 ` Thiago Jung Bauermann
2022-11-26 2:04 ` [PATCH v2 3/6] gdbserver/linux-aarch64: Factor out function to get aarch64_features Thiago Jung Bauermann
2022-11-28 11:54 ` Luis Machado
2022-11-29 3:19 ` Thiago Jung Bauermann
2022-11-28 15:12 ` Simon Marchi
2022-11-29 3:26 ` Thiago Jung Bauermann
2022-11-26 2:04 ` [PATCH v2 4/6] gdbserver/linux-aarch64: When thread stops, update its target description Thiago Jung Bauermann
2022-11-28 12:06 ` Luis Machado
2022-11-29 3:59 ` Thiago Jung Bauermann
2022-11-28 15:47 ` Simon Marchi
2022-11-28 16:01 ` Luis Machado
2022-11-28 16:07 ` Simon Marchi
2022-11-29 4:30 ` Thiago Jung Bauermann
2022-11-26 2:04 ` [PATCH v2 5/6] gdb/aarch64: Factor out most of the thread_architecture method Thiago Jung Bauermann
2022-11-28 12:09 ` Luis Machado [this message]
2022-11-29 4:32 ` Thiago Jung Bauermann
2022-11-28 16:09 ` Simon Marchi
2022-11-29 4:33 ` Thiago Jung Bauermann
2022-11-26 2:04 ` [PATCH v2 6/6] gdb/aarch64: Detect vector length changes when debugging remotely Thiago Jung Bauermann
2022-11-28 13:27 ` Luis Machado
2022-12-01 1:15 ` Thiago Jung Bauermann
2022-11-28 16:36 ` Simon Marchi
2022-12-01 3:16 ` Thiago Jung Bauermann
2022-12-01 8:32 ` Luis Machado
2022-12-01 16:16 ` Simon Marchi
2022-11-30 8:43 ` Luis Machado
2022-12-05 22:37 ` Thiago Jung Bauermann
2022-12-07 17:05 ` Luis Machado
2022-12-07 19:25 ` Simon Marchi
2022-12-07 23:01 ` Luis Machado
2022-12-09 2:20 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=832ac76f-4cc1-1ab4-a80c-f4d92005ea7e@arm.com \
--to=luis.machado@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=thiago.bauermann@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).