From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5276 invoked by alias); 20 Feb 2017 20:40:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5146 invoked by uid 89); 20 Feb 2017 20:40:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:aa362d1, Hx-languages-length:863, H*f:sk:7e414de, disas X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Feb 2017 20:40:22 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cfukv-00045U-CR from Luis_Gustavo@mentor.com ; Mon, 20 Feb 2017 12:40:21 -0800 Received: from [172.30.11.42] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Mon, 20 Feb 2017 12:40:18 -0800 Reply-To: Luis Machado Subject: Re: [PATCH] Introduce and use disassembly_flags References: <20170211031207.4682-1-simon.marchi@polymtl.ca> <5030fe47c2855e56139d7629d2e6e370@polymtl.ca> <7e414de440d77d9a11aac61eabcb9481@polymtl.ca> To: Simon Marchi CC: From: Luis Machado Message-ID: <8334f0f6-d478-662d-ec7f-546bc37b3199@codesourcery.com> Date: Mon, 20 Feb 2017 20:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <7e414de440d77d9a11aac61eabcb9481@polymtl.ca> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-02.mgc.mentorg.com (147.34.90.202) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00558.txt.bz2 On 02/20/2017 02:37 PM, Simon Marchi wrote: > On 2017-02-20 15:22, Luis Machado wrote: >> On 02/18/2017 01:23 PM, Simon Marchi wrote: >>> On 2017-02-13 15:02, Luis Machado wrote: >>>> Also, should we consider converting DISASSEMBLY_SOURCE_DEPRECATED or >>>> should we let it go? It was introduced in 2015. >>> >>> What do you mean by "converting"? >> >> Since it is deprecated, do we need to convert/carry it over to the >> enum definitions? If not, it could be dropped. >> >> I haven't looked much into this, so i'm not sure if we're still >> considering it acceptable to use this deprecated flag. > > This flag corresponds to the /m modifier of the disas command, which > itself has been deprecated in 7.11. As long as we don't remove the > modifier, we can't remove the flag. Fair enough. Thanks for the info.