From: Eli Zaretskii <eliz@gnu.org>
To: Lancelot Six <lancelot.six@amd.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 02/11] gdb/gdbsupport/gdbserver: Require c++17
Date: Fri, 13 Oct 2023 18:21:08 +0300 [thread overview]
Message-ID: <8334yetuor.fsf@gnu.org> (raw)
In-Reply-To: <20231013144418.3180617-3-lancelot.six@amd.com> (message from Lancelot Six on Fri, 13 Oct 2023 14:44:09 +0000)
> From: Lancelot Six <lancelot.six@amd.com>
> CC: Lancelot Six <lancelot.six@amd.com>
> Date: Fri, 13 Oct 2023 14:44:09 +0000
>
> This patch proposes to require a C++17 compiler to build gdb /
> gdbsupport / gdbserver. Before this patch, GDB required a C++11
> compiler.
>
> The general policy regarding bumping C++ language requirement in GDB (as
> stated in [1]) is:
>
> Our general policy is to wait until the oldest compiler that
> supports C++NN is at least 3 years old.
>
> Rationale: We want to ensure reasonably widespread compiler
> availability, to lower barrier of entry to GDB contributions, and to
> make it easy for users to easily build new GDB on currently
> supported stable distributions themselves. 3 years should be
> sufficient for latest stable releases of distributions to include a
> compiler for the standard, and/or for new compilers to appear as
> easily installable optional packages. Requiring everyone to build a
> compiler first before building GDB, which would happen if we
> required a too-new compiler, would cause too much inconvenience.
>
> See the policy proposal and discussion
> [here](https://sourceware.org/ml/gdb-patches/2016-10/msg00616.html).
>
> The first GCC release which with full C++17 support is GCC-9[2],
> released in 2019[3], which is over 4 years ago. Clang has had C++17
> support since Clang-5[4] released in 2018[5].
>
> A discussions with many distros showed that a C++17-able compiler is
> always available, meaning that this no hard requirement preventing us to
> require it going forward.
>
> [1] https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#When_is_GDB_going_to_start_requiring_C.2B-.2B-NN_.3F
> [2] https://gcc.gnu.org/projects/cxx-status.html#cxx17
> [3] https://gcc.gnu.org/gcc-9/
> [4] https://clang.llvm.org/cxx_status.html
> [5] https://releases.llvm.org/
>
> Change-Id: Id596f5db17ea346e8a978668825787b3a9a443fd
> ---
> gdb/NEWS | 3 +
> gdb/config.in | 4 +-
> gdb/configure | 1970 ++++++++++++++++++++++++++++++++++-----
> gdb/configure.ac | 4 +-
> gdbserver/config.in | 4 +-
> gdbserver/configure | 1970 ++++++++++++++++++++++++++++++++++-----
> gdbserver/configure.ac | 4 +-
> gdbsupport/Makefile.in | 2 +-
> gdbsupport/config.in | 4 +-
> gdbsupport/configure | 1970 ++++++++++++++++++++++++++++++++++-----
> gdbsupport/configure.ac | 4 +-
> 11 files changed, 5212 insertions(+), 727 deletions(-)
>
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 81264c0cfb3..8ab2e4c593a 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,9 @@
>
> *** Changes since GDB 14
>
> +* Building GDB and GDBserver now requires a C++17 compiler.
> + For example, GCC 9 or later.
> +
> * GDB index now contains information about the main function. This speeds up
> startup when it is being used for some large binaries.
The NEWS part is okay, thanks.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2023-10-13 15:21 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 14:44 [PATCH 00/11] GDB: Require C++17 Lancelot Six
2023-10-13 14:44 ` [PATCH 01/11] gdb/ax_cxx_compile_stdcxx.m4: upgrade Lancelot Six
2023-10-13 14:44 ` [PATCH 02/11] gdb/gdbsupport/gdbserver: Require c++17 Lancelot Six
2023-10-13 15:21 ` Eli Zaretskii [this message]
2023-10-16 21:50 ` Pedro Alves
2023-10-13 14:44 ` [PATCH 03/11] gdb: Use C++17's std::make_unique instead of gdb::make_unique Lancelot Six
2023-10-16 19:14 ` Tom Tromey
2023-10-17 14:02 ` Lancelot SIX
2023-10-13 14:44 ` [PATCH 04/11] gdb: Replace gdb::optional with std::optional Lancelot Six
2023-10-13 14:44 ` [PATCH 05/11] gdbsupport: remove gdb::optional Lancelot Six
2023-10-13 14:44 ` [PATCH 06/11] gdb: Use std::string_view instead of gdb::string_view Lancelot Six
2023-10-14 21:50 ` Tom Tromey
2023-10-14 23:58 ` Six, Lancelot
2023-10-16 15:06 ` Lancelot SIX
2023-10-16 19:35 ` Tom Tromey
2023-10-16 21:51 ` Pedro Alves
2023-10-17 14:13 ` Lancelot SIX
2023-10-17 14:20 ` Simon Marchi
2023-10-13 14:44 ` [PATCH 07/11] gdb: Remove uses of gdb::to_string (const std::string_view &) Lancelot Six
2023-10-13 14:44 ` [PATCH 08/11] gdbsupport: Remove gdb::string_view Lancelot Six
2023-10-16 19:38 ` Tom Tromey
2023-10-13 14:44 ` [PATCH 09/11] gdbsupport: Replace gdb::invoke_result with std::invoke_result Lancelot Six
2023-10-13 14:44 ` [PATCH 10/11] gdb/disasm.h: Mark callbacks noexcept unconditionally Lancelot Six
2023-10-16 21:51 ` Pedro Alves
2023-10-13 14:44 ` [PATCH 11/11] gdb: Use initializers in lambda captures unconditionally Lancelot Six
2023-10-16 19:43 ` [PATCH 00/11] GDB: Require C++17 Tom Tromey
2023-10-16 21:53 ` Pedro Alves
2023-10-23 13:42 ` Lancelot SIX
2023-10-28 20:48 ` Lancelot SIX
2023-11-21 12:04 ` [COMMITTED PATCH v2 0/9] " Lancelot Six
2023-11-21 12:04 ` [COMMITTED PATCH v2 1/9] gdb: Use C++17's std::make_unique instead of gdb::make_unique Lancelot Six
2023-11-21 12:04 ` [COMMITTED PATCH v2 2/9] gdb: Replace gdb::optional with std::optional Lancelot Six
2023-11-21 12:04 ` [COMMITTED PATCH v2 3/9] gdbsupport: remove gdb::optional Lancelot Six
2023-11-21 12:04 ` [COMMITTED PATCH v2 4/9] gdb: Use std::string_view instead of gdb::string_view Lancelot Six
2023-11-21 12:04 ` [COMMITTED PATCH v2 5/9] gdb: Remove uses of gdb::to_string (const std::string_view &) Lancelot Six
2023-11-21 12:04 ` [COMMITTED PATCH v2 6/9] gdbsupport: Remove gdb::string_view Lancelot Six
2023-11-21 12:04 ` [COMMITTED PATCH v2 7/9] gdbsupport: Replace gdb::invoke_result with std::invoke_result Lancelot Six
2023-11-21 12:04 ` [COMMITTED PATCH v2 8/9] gdb/disasm.h: Mark callbacks noexcept unconditionally Lancelot Six
2023-11-21 12:05 ` [COMMITTED PATCH v2 9/9] gdb: Use initializers in lambda captures unconditionally Lancelot Six
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8334yetuor.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).