From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 7CDDE3858D1E for ; Mon, 9 Jan 2023 16:41:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7CDDE3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEvDE-0000Sj-PC; Mon, 09 Jan 2023 11:41:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4l1osz2+6/R70irEmI9IXzW0RXVRALwmv3MY7QNS82w=; b=o4QjH58VCgvM v7y7kXvAnr2QqE81wrwW2OeYyLij1zJ0uijac68Hp86Z1m1gfg/QPu+lclpV6H/yMm7nXO98fqX2Y A1NLnL3cboGQdYkqzX26/t2xcC5rWoc0ayBRIBkyWfeJ08YEyokFikalZz7LAWIbgJhriE27ge+7g d0zfvoJFN078LTtANXL8rcs/Ek9k0QBV2+wO1m+R6vJL4NpXEQKfdguZOiHozBKzip2ySClayQ4fW VfAsFyYokmsNn6gdGH2ZOsbzvug4xRJMn/5jefrR77CPcdztV9+jCgYFSIHJ6P6JPclV2/hXgA7Zj xJ/68YeK9E9IE1BoFd598w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEvDD-0004GP-Sl; Mon, 09 Jan 2023 11:41:28 -0500 Date: Mon, 09 Jan 2023 18:41:51 +0200 Message-Id: <83358jpsmo.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey Cc: gdb-patches@sourceware.org In-Reply-To: <20230109144716.1988567-1-tromey@adacore.com> (message from Tom Tromey via Gdb-patches on Mon, 9 Jan 2023 07:47:16 -0700) Subject: Re: [PATCH] Set _WIN32_WINNT in common.m4 configure check References: <20230109144716.1988567-1-tromey@adacore.com> X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: Tom Tromey > Date: Mon, 9 Jan 2023 07:47:16 -0700 > From: Tom Tromey via Gdb-patches > > GCC recently added support for the Windows thread model, enabling > libstdc++ to support Windows natively. However, this supporrt > requires a version of Windows later than the minimum version that is > supported by GDB. > > PR build/29966 points out that the GDB configure test for std::thread > does not work in this situation, because _WIN32_WINNT is not defined > in test program, and so seems to be fine. > > This patch is an attempt to fix the problem, by using the same setting > for _WIN32_WINNT at configure time as is used at build time. > > I don't have access to one of the older systems so I don't think I can > truly test this. I did do a mingw cross build, though. I'm going to > ask the bug reporter to test it. The patch LGTM, but of course actually testing on an old system would be the best. Thanks.