From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id BC8773858429 for ; Fri, 9 Sep 2022 15:57:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BC8773858429 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47558) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWgNc-0001FL-Jd; Fri, 09 Sep 2022 11:57:20 -0400 Received: from [87.69.77.57] (port=1956 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWgNc-0005dK-0e; Fri, 09 Sep 2022 11:57:20 -0400 Date: Fri, 09 Sep 2022 18:57:14 +0300 Message-Id: <8335d0czhh.fsf@gnu.org> From: Eli Zaretskii To: Christina Schimpe Cc: gdb-patches@sourceware.org, pedro@palves.net, aburgess@redhat.com, tom@tromey.com In-Reply-To: <20220909153709.3687178-3-christina.schimpe@intel.com> (message from Christina Schimpe on Fri, 9 Sep 2022 17:37:08 +0200) Subject: Re: [PATCH v3 2/3] gdb: Add per-remote target variables for memory read and write config References: <20220909153709.3687178-1-christina.schimpe@intel.com> <20220909153709.3687178-3-christina.schimpe@intel.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Sep 2022 15:57:27 -0000 > From: Christina Schimpe > Cc: pedro@palves.net, > aburgess@redhat.com, > eliz@gnu.org, > tom@tromey.com, > Christina Schimpe > Date: Fri, 9 Sep 2022 17:37:08 +0200 > > diff --git a/gdb/NEWS b/gdb/NEWS > index d1ed7f015f9..9b22a626868 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -11,8 +11,15 @@ > configure a target's feature packet and to display its configuration, > respectively. > > - The configuration of the packet itself applies to the currently selected > - target (if available). If no target is selected, it applies to future remote > + The individual packet sizes can be configured and shown using the commands > + ** 'set remote memory-read-packet-size (number of bytes|fixed|limit)' > + ** 'set remote memory-write-packet-size (number of bytes|fixed|limit)' > + ** 'show remote memory-read-packet-size' > + ** 'show remote memory-write-packet-size'. > + > + The configuration of the packet itself, as well as the size of a memory-read > + or memory-write packet applies to the currently selected target (if > + available). If no target is selected, it applies to future remote > connections. Similarly, the show commands print the configuration of the > currently selected target. If no remote target is selected, the default > configuration for future connections is shown. This part is OK. > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -23959,6 +23959,20 @@ future connections is shown. The available settings are: > > @end multitable > > +@cindex configuration of the remote packet size A better index entry would start with "remote packet size", because users are more likely to have that in mind than the general-purpose word like "configuration". For even better results, add one more index entry sat=ying @cindex packet size, remote, configuring > +The number of bytes per memory-read or memory-write packet for a remote target > +can be configured using the commands @code{set remote memory-read-packet-size} > +and @code{set remote memory-write-packet-size}. If set to @samp{0} (zero) the The commands should be in @w{..}, to make sure they aren't split between two lines, which makes them harder to read. Thanks.