From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id C02CC3857C6F
 for <gdb-patches@sourceware.org>; Sun, 11 Apr 2021 06:41:32 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C02CC3857C6F
Received: from fencepost.gnu.org ([2001:470:142:3::e]:57822)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1lVTml-0007wB-As; Sun, 11 Apr 2021 02:41:31 -0400
Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4227
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1lVTmk-0001kx-Mq; Sun, 11 Apr 2021 02:41:31 -0400
Date: Sun, 11 Apr 2021 09:41:12 +0300
Message-Id: <8335vx5nnb.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Zied Guermazi <zied.guermazi@trande.de>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20210410211744.7662-3-zied.guermazi@trande.de> (message from
 Zied Guermazi on Sat, 10 Apr 2021 23:17:39 +0200)
Subject: Re: [PATCH v4 2/7] add btrace coresight related commands
References: <20210410211744.7662-1-zied.guermazi@trande.de>
 <20210410211744.7662-3-zied.guermazi@trande.de>
X-Spam-Status: No, score=1.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Apr 2021 06:41:33 -0000

> From: Zied Guermazi <zied.guermazi@trande.de>
> Date: Sat, 10 Apr 2021 23:17:39 +0200
> Cc: Zied Guermazi <zied.guermazi@trande.de>
> 
> This patch extends the commands needed for using branch tracing
> with ARM CoreSight traces.
> Those commands are:
> set record btrace etm sink
> set record btrace etm buffer-size
> record btrace etm
> 
> gdb/ChangeLog
> 
> 	* NEWS: list new commands for extending btrace
> 	to support using ARM CoreSight Traces.
> 	* record-btrace.c (record_btrace_print_etm_conf): New.
> 	(record_btrace_print_conf): handle BTRACE_FORMAT_ETM.
> 	(cmd_record_btrace_etm_start): New.
> 	(cmd_record_btrace_start): handle starting ETM tracing.
> 	(cmd_show_record_btrace_cpu): extend for ARM cpus.
> 	(show_record_etm_buffer_size_value): New.
> 	(_initialize_record_btrace): add commands for ETM traces.
> 	(record_start): add starting ETM traces.
> 
> gdb/doc/ChangeLog
> 
> 	* gdb.texinfo (Process Record and Replay): Document extending 
> 	GDB btrace commands to support using ARM CoreSight traces.
> 
> gdbsupport/ChangeLog
> 
> 	* btrace-common.h (btrace_format): add BTRACE_FORMAT_ETM
> 	to the enum.
> 	(btrace_config_etm): new struct.
> 	(btrace_config): add btrace_config_etm etm.
> 	* btrace-common.cc (btrace_format_string): add BTRACE_FORMAT_ETM.
> 	(btrace_format_short_string): add BTRACE_FORMAT_ETM.

Were there any changes since the last version in the documentation
parts?  In any case, the documentation parts are okay.

Thanks.