From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87149 invoked by alias); 23 May 2018 19:21:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87050 invoked by uid 89); 23 May 2018 19:21:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:3649 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 May 2018 19:21:36 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLZKF-0000KM-Jp for gdb-patches@sourceware.org; Wed, 23 May 2018 15:21:34 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48289) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLZJm-00008w-L7; Wed, 23 May 2018 15:21:02 -0400 Received: from [176.228.60.248] (port=2920 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fLZJl-0006fd-FX; Wed, 23 May 2018 15:21:02 -0400 Date: Wed, 23 May 2018 23:40:00 -0000 Message-Id: <8336yich5s.fsf@gnu.org> From: Eli Zaretskii To: Sergio Durigan Junior CC: gdb-patches@sourceware.org, palves@redhat.com, jan.kratochvil@redhat.com, fercerpav@gmail.com, sekiriki@gmail.com In-reply-to: <20180523185719.22832-1-sergiodj@redhat.com> (message from Sergio Durigan Junior on Wed, 23 May 2018 14:57:19 -0400) Subject: Re: [PATCH] Implement IPv6 support for GDB/gdbserver Reply-to: Eli Zaretskii References: <20180523185719.22832-1-sergiodj@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00632.txt.bz2 > From: Sergio Durigan Junior > Cc: Pedro Alves , > Eli Zaretskii , > Jan Kratochvil , > Paul Fertser , > Tsutomu Seki , > Sergio Durigan Junior > Date: Wed, 23 May 2018 14:57:19 -0400 > > gdb/ChangeLog: > yyyy-mm-dd Sergio Durigan Junior > Jan Kratochvil > Paul Fertser > Tsutomu Seki > > * Makefile.in (COMMON_SFILES): Add 'common/netstuff.c'. > (HFILES_NO_SRCDIR): Add 'common/netstuff.h'. > * NEWS (Changes since GDB 8.1): Mention IPv6 support. > * common/netstuff.c: New file. > * common/netstuff.h: New file. > * ser-tcp.c: Include 'netstuff.h' and 'wspiapi.h'. > (net_open): Handle IPv6-style hostnames; implement support for > IPv6 connections. > > gdb/gdbserver/ChangeLog: > yyyy-mm-dd Sergio Durigan Junior > Jan Kratochvil > Paul Fertser > Tsutomu Seki > > * Makefile.in (SFILES): Add '$(srcdir)/common/netstuff.c'. > (OBS): Add 'common/netstuff.o'. > * gdbreplay.c: Include 'wspiapi.h'. > (remote_open): Implement support for IPv6 > connections. > * remote-utils.c: Include 'netstuff.h', 'filestuff.h' > and 'wspiapi.h'. > (handle_accept_event): Accept connections from IPv6 sources. > (remote_prepare): Handle IPv6-style hostnames; implement > support for IPv6 connections. > (remote_open): Implement support for printing connections from > IPv6 sources. > > gdb/testsuite/ChangeLog: > yyyy-mm-dd Sergio Durigan Junior > Jan Kratochvil > Paul Fertser > Tsutomu Seki > > * README (Testsuite Parameters): Mention new 'GDB_TEST_IPV6' > parameter. > * boards/gdbserver-base.exp (get_comm_port_localhost_ipv6): > New procedure. > * boards/native-extended-gdbserver.exp: Detect 'GDB_TEST_IPV6' > and change board info accordingly. > * boards/native-gdbserver.exp: Likewise. > * gdb.server/run-without-local-binary.exp: Improve regexp used > for detecting when a remote debugging connection succeeds. > > gdb/doc/ChangeLog: > yyyy-mm-dd Sergio Durigan Junior > Jan Kratochvil > Paul Fertser > Tsutomu Seki > > * gdb.texinfo (Remote Connection Commands): Add explanation > about new IPv6 support. Add new connection prefixes. The documentation parts are approved, with a couple of minor comments: > @item target remote @code{@var{host}:@var{port}} > +@itemx target remote @code{@var{@r{[}host@r{]}}:@var{port}} Isn't having 2 lines here redundant? If the HOST part is optional, the second line already covers the first, right? Similarly with other forms of this command. > @item target remote @code{udp:@var{host}:@var{port}} > +@itemx target remote @code{udp:@var{host}:@var{port}} And here these two lines are exactly identical, right? > +To connect to port 2828 on a terminal server whose address is > +@code{2001::f8ff::67cf}, you can either use the square bracket syntax: > + > +@smallexample > +target remote [2001::f8ff::67cf]:2828 > +@end smallexample > + > +Or explicitly specify the @acronym{IPv6} protocol: The last sentence is actually a continuation of the one before the example. So it should start with a lower-case letter, and please insert a @noindent (on its own line) before that, to prevent Texnfo processors from indenting that line. Thanks.