From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28614 invoked by alias); 3 Mar 2018 07:36:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28594 invoked by uid 89); 3 Mar 2018 07:36:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*r:47205, Hx-languages-length:1460 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 03 Mar 2018 07:36:51 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1es1io-0001nz-0W for gdb-patches@sourceware.org; Sat, 03 Mar 2018 02:36:49 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1es1ie-0001jn-L3; Sat, 03 Mar 2018 02:36:36 -0500 Received: from [176.228.60.248] (port=4053 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1es1id-00010y-PH; Sat, 03 Mar 2018 02:36:36 -0500 Date: Sat, 03 Mar 2018 07:36:00 -0000 Message-Id: <83371hwqy5.fsf@gnu.org> From: Eli Zaretskii To: Sergio Durigan Junior CC: simon.marchi@polymtl.ca, gdb-patches@sourceware.org, palves@redhat.com, brobecker@adacore.com, christophe.lyon@linaro.org In-reply-to: <87fu5i5og9.fsf@redhat.com> (message from Sergio Durigan Junior on Fri, 02 Mar 2018 13:20:38 -0500) Subject: Re: [PATCH] Conditionally include "" on common/pathstuff.c (and unbreak build on mingw*) Reply-to: Eli Zaretskii References: <20180301202005.11563-1-sergiodj@redhat.com> <83h8pywqku.fsf@gnu.org> <625c70bb51eb88e5448d935d523d5919@polymtl.ca> <87fu5i5og9.fsf@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00088.txt.bz2 > From: Sergio Durigan Junior > Cc: Eli Zaretskii , gdb-patches@sourceware.org, simon.marchi@ericsson.com, palves@redhat.com, brobecker@adacore.com, christophe.lyon@linaro.org > Date: Fri, 02 Mar 2018 13:20:38 -0500 > > >>> +#ifdef USE_WIN32API > >>> +#include > >>> +#endif > >> > >> Isn't USE_WIN32API specific to gdbserver? If so, perhaps it's better > >> to use __MINGW32__ or _WIN32 instead? > > > > I see it defined in both gdb and gdbserver: > > > > https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/configure.ac;h=698fc7b83456f8c5a63ae0050dc8ec65069290f7;hb=HEAD#l1908 > > https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/gdbserver/configure.ac;h=99801681ff47ee8dcd9ad2e5ae282dcd113c83e4;hb=HEAD#l281 > > It's also present on common/filestuff.c, which is shared. That's > actually where I took the idea from. Those could be mistakes due to moving stuff into common/. So I think we should decide what that symbol means and how to use it, and then see if the practice somehow deviates from those rules. I asked my question because AFAIR this symbol used to be only in gdbserver sources. If nowadays we can use it anywhere, then I'd suggest to replace it with something common with GDB, because the meaning of USE_WIN32API in the context of GDB is unclear to me.