From: Eli Zaretskii <eliz@gnu.org>
To: Luis Machado <lgustavo@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] [BZ 21005] Add support for Intel 64 rdrand and rdseed record/replay
Date: Thu, 26 Jan 2017 19:36:00 -0000 [thread overview]
Message-ID: <8337g53984.fsf@gnu.org> (raw)
In-Reply-To: <1485451129-16439-2-git-send-email-lgustavo@codesourcery.com> (message from Luis Machado on Thu, 26 Jan 2017 11:18:49 -0600)
> From: Luis Machado <lgustavo@codesourcery.com>
> Date: Thu, 26 Jan 2017 11:18:49 -0600
>
> The following patch addresses BZ 21005, which is gdb failing to
> recognize an rdrand instruction.
>
> It enables support for both rdrand and rdseed and handles extended register
> addressing (R8~R15) for 16-bit, 32-bit and 64-bit.
>
> I tested this by hand with quite a few lines of inline asm. I thought we
> had arch-specific tests in testsuite/, but it looks like we don't exercise
> every little instruction with record/replay, so no testcase. Let me know
> if one is required.
>
> Regression-tested on Ubuntu 16.04 x86-64.
>
> Testsuite results are as follows:
>
> === gdb Summary ===
>
> # of expected passes 159
>
> OK?
>
> gdb/ChangeLog
>
> 2017-01-26 Luis Machado <lgustavo@codesourcery.com>
>
> * NEWS: Mention support for record/replay of Intel 64 rdrand and
> rdseed instructions.
> i386-tdep.c (i386_process_record): Handle Intel 64 rdrand and rseed.
OK for the NEWS part.
next prev parent reply other threads:[~2017-01-26 19:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 17:19 [PATCH 1/2] Add rdrand/rdseed record/replay tests Luis Machado
2017-01-26 17:19 ` [PATCH 2/2] [BZ 21005] Add support for Intel 64 rdrand and rdseed record/replay Luis Machado
2017-01-26 19:36 ` Eli Zaretskii [this message]
2017-02-01 11:11 ` Pedro Alves
2017-01-26 17:23 ` [PATCH 1/2] Add rdrand/rdseed record/replay tests Luis Machado
2017-02-01 11:11 ` Pedro Alves
2017-02-01 11:09 ` Pedro Alves
2017-02-01 12:42 ` Luis Machado
2017-02-01 12:55 ` Luis Machado
2017-02-01 15:38 ` Pedro Alves
2017-02-06 9:16 ` Luis Machado
2017-02-23 16:23 ` Yao Qi
2017-02-23 17:20 ` Luis Machado
2017-02-23 17:26 ` Luis Machado
2017-02-23 21:42 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8337g53984.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).