From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122982 invoked by alias); 21 Jul 2016 14:36:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122973 invoked by uid 89); 21 Jul 2016 14:36:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:cable.0, HX-HELO:eggs.gnu.org, Hx-spam-relays-external:208.118.235.92, H*RU:208.118.235.92 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 21 Jul 2016 14:36:12 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQF53-0005ZC-6n for gdb-patches@sourceware.org; Thu, 21 Jul 2016 10:36:10 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQF53-0005Z8-3e; Thu, 21 Jul 2016 10:36:05 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4925 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bQF52-0004E3-7t; Thu, 21 Jul 2016 10:36:04 -0400 Date: Thu, 21 Jul 2016 14:36:00 -0000 Message-Id: <8337n3ys6c.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: gdb-patches@sourceware.org In-reply-to: <1469103990-8482-1-git-send-email-palves@redhat.com> (message from Pedro Alves on Thu, 21 Jul 2016 13:26:30 +0100) Subject: Re: [PATCH] Fix djgpp gdb build Reply-to: Eli Zaretskii References: <1469103990-8482-1-git-send-email-palves@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00259.txt.bz2 > From: Pedro Alves > Date: Thu, 21 Jul 2016 13:26:30 +0100 > > - A few missing casts required by C++, resulting in: > > ../../src/gdb/ser-go32.c:795:21: error: invalid conversion from 'const void*' to 'const char*' [-fpermissive] > > etc. > > - dos_noop has an incompatible prototype with struct serial_ops's > setparity, resulting in: > > ../../src/gdb/ser-go32.c:874:1: error: invalid conversion from 'int (*)(serial*)' to 'int (*)(serial*, int)' [-fpermissive] > > (I thought of calling the ser-base.c default methods, but djgpp > doesn't include ser-base.c in the build.) > > gdb/ChangeLog: > 2016-07-21 Pedro Alves > > * go32-nat.c (go32_create_inferior): Add cast. > * ser-go32.c (dos_noop): Delete. > (dos_flush_output, dos_setparity, dos_drain_output): New > functions. > (dos_write): Add cast. > (dos_ops): Use dos_flush_output, dos_setparity and > dos_drain_output. > * top.c (do_chdir_cleanup): Add cast. OK. Thanks for taking care of this port.