public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Star wildcard ranges (e.g., "info thread 2.*")
Date: Thu, 14 Jan 2016 16:16:00 -0000	[thread overview]
Message-ID: <8337u0i1ac.fsf@gnu.org> (raw)
In-Reply-To: <569782EB.2030509@redhat.com> (message from Pedro Alves on Thu,	14 Jan 2016 11:13:47 +0000)

> Date: Thu, 14 Jan 2016 11:13:47 +0000
> From: Pedro Alves <palves@redhat.com>
> CC: gdb-patches@sourceware.org
> 
> >> +* In commands that accept thread IDs lists, you can now refer to all
> > 
> > "thread ID lists", only one word in plural.  Or maybe even better:
> > "lists of thread IDs".
> 
> Hmm, going further, I think that "list" should be singular too:
> 
>  In commands that accept a thread ID list, you can now refer to all
>  In commands that accept a list of thread IDs, you can now refer to all
> 
> I prefer the former because "thread ID list" is a defined term in
> the manual.

I won't bykeshed over it, but just so you know: use of double "status
constructus" in English is not a good style, because it is ambiguous
-- is "thread ID list" an ID list of a thread or a list of thread
IDs?  The simple "list of thread IDs" disambiguates that.

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index fbc76fa..a08a196 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -2916,17 +2916,17 @@ argument.  A list element can be:
> 
>  @enumerate
>  @item
> -a thread ID as shown in the first field of the @samp{info threads}
> +A thread ID as shown in the first field of the @samp{info threads}
>  display, with or without an inferior qualifier.  E.g., @samp{2.1} or
>  @samp{1}.
> 
>  @item
> -a range of thread numbers, again with or without an inferior
> +A range of thread numbers, again with or without an inferior
>  qualifier, as in @var{inf}.@var{thr1}-@var{thr2} or
>  @var{thr1}-@var{thr2}.  E.g., @samp{1.2-4} or @samp{2-4}.
> 
>  @item
> -all threads of an inferior, specified with a star wildcard, with or
> +All threads of an inferior, specified with a star wildcard, with or
>  without an inferior qualifier, as in @var{inf}.@code{*} (e.g.,
>  @samp{1.*}) or @code{*}.  The former refers to all threads of the
>  given inferior, and the latter form without an inferior qualifier

Thanks, this is OK.

  reply	other threads:[~2016-01-14 16:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-13 16:34 [PATCH 0/2] " Pedro Alves
2016-01-13 16:34 ` [PATCH 2/2] " Pedro Alves
2016-01-13 17:00   ` Eli Zaretskii
2016-01-14 11:13     ` Pedro Alves
2016-01-14 16:16       ` Eli Zaretskii [this message]
2016-01-14 16:42         ` Pedro Alves
2016-01-14 11:29   ` Pedro Alves
2016-01-13 16:34 ` [PATCH 1/2] Fix "thread apply $conv_var" and misc other related problems Pedro Alves
2016-01-13 16:34 ` [PATCH 0/2] Star wildcard ranges (e.g., "info thread 2.*") Pedro Alves
2016-01-13 16:42   ` Pedro Alves
2016-01-14 16:52 ` Simon Marchi
2016-01-15 21:50 ` Pedro Alves
2016-01-14 11:39 Pedro Alves
2016-01-14 11:39 ` [PATCH 2/2] " Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8337u0i1ac.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).