From: Eli Zaretskii <eliz@gnu.org>
To: Doug Evans <xdje42@gmail.com>
Cc: gbenson@redhat.com, gdb-patches@sourceware.org,
aburgess@broadcom.com, fw@deneb.enyo.de, mark.kettenis@xs4all.nl,
palves@redhat.com, tromey@redhat.com
Subject: Re: [PATCH 2/2 v3] Demangler crash handler
Date: Thu, 05 Jun 2014 02:54:00 -0000 [thread overview]
Message-ID: <8338fk6p8p.fsf@gnu.org> (raw)
In-Reply-To: <CAP9bCMSPY+=fy-2gNcfK-qeiSkDg-0g8BjJnaQeGjcyRkK5V1w@mail.gmail.com>
> Date: Wed, 4 Jun 2014 18:11:16 -0700
> From: Doug Evans <xdje42@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
> Andrew Burgess <aburgess@broadcom.com>, Florian Weimer <fw@deneb.enyo.de>,
> Mark Kettenis <mark.kettenis@xs4all.nl>, Pedro Alves <palves@redhat.com>,
> Tom Tromey <tromey@redhat.com>
>
> One thing that I think should be considered is that we'll go from the
> simple state of "just ifdef every signal" in places like
> common/signals.c to having some signals you are required to not ifdef
> and some you do, and needing to know which category every signal fits
> in. I don't have a strong opinion, but I'm ok with the status quo.
The list of ANSI-standard signals is short, and it's easy to check
which signal is or isn't.
Ifdef's are ugly. Minimizing their use is a Good Thing.
next prev parent reply other threads:[~2014-06-05 2:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 10:08 [PATCH 0/2 " Gary Benson
2014-06-04 10:09 ` [PATCH 1/2 v3] Add new internal problem for demangler warnings Gary Benson
2014-06-04 10:18 ` Eli Zaretskii
2014-06-04 13:34 ` Gary Benson
2014-06-04 10:10 ` [PATCH 2/2 v3] Demangler crash handler Gary Benson
2014-06-04 10:20 ` Eli Zaretskii
2014-06-04 13:36 ` Gary Benson
2014-06-04 13:41 ` Eli Zaretskii
2014-06-04 14:28 ` Gary Benson
2014-06-04 15:24 ` Doug Evans
2014-06-04 18:25 ` Gary Benson
2014-06-05 1:11 ` Doug Evans
2014-06-05 2:54 ` Eli Zaretskii [this message]
2014-06-04 16:05 ` Doug Evans
2014-06-04 18:34 ` Gary Benson
2014-06-04 10:21 ` [PATCH 0/2 " Eli Zaretskii
2014-06-04 13:41 ` Gary Benson
2014-06-04 13:49 ` Eli Zaretskii
2014-06-04 14:28 ` Gary Benson
2014-06-04 10:28 ` Mark Kettenis
2014-06-04 13:34 ` Gary Benson
2014-06-04 14:54 ` Andrew Burgess
2014-06-04 15:52 ` Doug Evans
2014-06-04 15:57 ` Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8338fk6p8p.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=aburgess@broadcom.com \
--cc=fw@deneb.enyo.de \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).