From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8823 invoked by alias); 30 Jun 2010 18:14:14 -0000 Received: (qmail 8810 invoked by uid 22791); 30 Jun 2010 18:14:12 -0000 X-SWARE-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Jun 2010 18:14:06 +0000 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0L4U00J00ALWMH00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Wed, 30 Jun 2010 21:14:03 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.229.12.240]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L4U00JJXANEJZ00@a-mtaout23.012.net.il>; Wed, 30 Jun 2010 21:14:03 +0300 (IDT) Date: Wed, 30 Jun 2010 18:14:00 -0000 From: Eli Zaretskii Subject: Re: Static tracepoints support In-reply-to: <201006292159.49527.pedro@codesourcery.com> To: Pedro Alves Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <8339w4bd3q.fsf@gnu.org> References: <201006251931.57860.pedro@codesourcery.com> <201006281326.39820.pedro@codesourcery.com> <83iq52c49n.fsf@gnu.org> <201006292159.49527.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00695.txt.bz2 > From: Pedro Alves > Date: Tue, 29 Jun 2010 21:59:48 +0100 > > Hmm, how about I add a column with a counter, for ease of reading. This > can't be expected to be stable, but should help readabily --- for example, > dynamically loaded or unloaded shared libraries can change the number of > markers in the program. Let me give it a try ... [done]. I think it's a good idea. I just hope users will not think that the number has the same semantics as with breakpoints. I see you did mention that in the manual. > I've spent a while trying to get something that look better, > and here's the current status: > > (gdb) info static-tracepoint-markers > Cnt ID Enb Address What > 1 metadata/core_marker_format n 0x00007fc3d7466692 > Data: "channel %s name %s format %s" > 2 metadata/core_marker_format n 0x00007fc3d7467897 > Data: "channel %s name %s format %s" > 3 metadata/core_marker_id n 0x00007fc3d746857d > Data: "channel %s name %s event_id %hu int #1u%zu long #1u%zu pointer #1u%zu size_t #1u%zu alignment #1u%u" > 4 metadata/core_marker_id n 0x00007fc3d7468a04 > Data: "channel %s name %s event_id %hu int #1u%zu long #1u%zu pointer #1u%zu size_t #1u%zu alignment #1u%u" > 5 metadata/core_marker_id n 0x00007fc3d746a006 > Data: "channel %s name %s event_id %hu int #1u%zu long #1u%zu pointer #1u%zu size_t #1u%zu alignment #1u%u" > 6 metadata/core_marker_format n 0x00007fc3d746a235 > Data: "channel %s name %s format %s" > 7 ust/potential_exec n 0x00007fc3d7487240 > Data: " " > 8 ust/bar2 y 0x0000000000400c98 in main at stexample.c:40 > Data: "number1 %d number2 %d" > Probed by static tracepoints: #2 > 9 ust/bar2 n 0x0000000000400df9 in main at stexample.c:41 > Data: "number1 %d number2 %d" > 10 ust/bar33 n 0x0000000000400fe0 in main at stexample.c:39 > Data: "str %s" > 11 ust/dummymark n 0x00000000004011a8 > Data: " " Thanks, I think this is better. > > But only if the conditionals are different. > > > > Anyway, it confused me, so perhaps it's a good idea to clarify. > > Okay, I agree, though I'd prefer to do that as a follow up, where I > change both the break- and tracepoint command's help output at once. > Is that okay with you? Yes. > Here's a new version of the patch integrating all of the > above. Any further comments? Just three: > + $_sdata internal variable. When analying the trace buffer, you can ^^^^^^^^ A typo (sorry I didn't catch that before). > +Whether the breakpoint is marked to be disabled or deleted when hit. Wasn't there supposed to be an @item before this sentence? > +UST backend, this is the the format string passed as argument to the ^^^ Redundant "the". Okay with those changes. Thanks.