Re: [PATCH] gdb/python: Add new gdb.Value.bytes attribute

[Eli Zaretskii <eliz@gnu.org>]

> From: Andrew Burgess <aburgess@redhat.com>
> Cc: Andrew Burgess <aburgess@redhat.com>
> Date: Wed, 18 Oct 2023 15:57:15 +0100
> 
>  gdb/NEWS                              |  3 ++
>  gdb/doc/python.texi                   |  7 ++++
>  gdb/python/py-value.c                 | 35 +++++++++++++++++
>  gdb/testsuite/gdb.python/py-value.exp | 56 ++++++++++++++++++++++++++-
>  4 files changed, 100 insertions(+), 1 deletion(-)
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 08d779010f0..d89df5dbb45 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -11,6 +11,9 @@
>    ** New function gdb.notify_mi(NAME, DATA), that emits custom
>       GDB/MI async notification.
>  
> +  ** New attribute gdb.Value.bytes that contains a bytes object
> +     holding the contents of this value.
> +
>  *** Changes in GDB 14
>  
>  * GDB now supports the AArch64 Scalable Matrix Extension 2 (SME2), which
> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
> index 546b4d4b962..a2db6c1b863 100644
> --- a/gdb/doc/python.texi
> +++ b/gdb/doc/python.texi
> @@ -916,6 +916,13 @@
>  method is invoked.  
>  @end defvar
>  
> +@defvar Value.bytes
> +The value of this read-only attribute is a @code{bytes} object
> +containing the bytes that make up this Value's value.  If the complete
                                          ^^^^^
I think "Value" should be in @code.

> +contents of this value are not available then accessing this attribute
> +will raise an exception.
> +@end defvar
> +

The documentation parts are okay, but I wonder: is it enough to say
"the bytes that make up this Value"?  Shouldn't we say something about
endianness, for example?  Or what are "the bytes" of a string with
non-ASCII characters in it?