From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 603463858C83 for ; Tue, 16 May 2023 19:20:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 603463858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pz0E2-0005wR-O7; Tue, 16 May 2023 15:20:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FXa7Cjwz8/f8w5NYTm8cAh9C9XnTeYE+mGYPMqcKUMQ=; b=AGne8j9ICd3w cPehjc6t8SUS/GuTmIHqeAm8f74sq0/vYvS79d9VTEDHNxuBhSOjy82H1wnn4abH2hoMWoiaaBei5 HjlXVpnugK92WAZ/JxMsNsMahUK/o8vHn5NRA+uZPpX8OW3G8ePzCdQisIE00AbWjZuaxwWnOiyJY 4E/lw3lY7ovhOSBlKXZSvvRJP1pz9ozT0Biij2oCTT5b3dwXZlCcTICMO+kKfkd2hKCE4a/aRFVjl avSfeFhSGr7ujy6GXF1QiGSpoQuh/Bqx/GQRVICdWO6r7+eUHJh5KpVwp1kA35eI5KftgB51W2/lo 9yjsY9jhRBjtQ7YKo5pOlA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pz0E1-0003AH-Vm; Tue, 16 May 2023 15:20:46 -0400 Date: Tue, 16 May 2023 22:20:53 +0300 Message-Id: <834jocytey.fsf@gnu.org> From: Eli Zaretskii To: tromey@adacore.com CC: gdb-patches@sourceware.org In-Reply-To: <835y8sytvl.fsf@gnu.org> (message from Eli Zaretskii via Gdb-patches on Tue, 16 May 2023 22:10:54 +0300) Subject: Re: [PATCH 2/2] Add "args" and "env" parameters to DAP launch request References: <20230509-dap-args-v1-0-16b5f0aa5cd6@adacore.com> <20230509-dap-args-v1-2-16b5f0aa5cd6@adacore.com> <83zg6da3jp.fsf@gnu.org> <87pm7014gu.fsf@tromey.com> <835y8sytvl.fsf@gnu.org> X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Date: Tue, 16 May 2023 22:10:54 +0300 > Cc: gdb-patches@sourceware.org > X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, > DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, > RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP, > T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 > From: Eli Zaretskii via Gdb-patches > > > From: Tom Tromey > > Cc: Tom Tromey , gdb-patches@sourceware.org > > Date: Tue, 16 May 2023 13:06:09 -0600 > > > > >> +@item env > > >> +If provided, this should be an object where each value is a string. > > > > Eli> This doesn't say what should those string values be. Shouldn't they > > Eli> be of the format "@var{variable}=@var{value}"? > > > > In JSON an object is a dictionary; so the keys are strings and the > > values are as well. That is it looks like {"variable": "value"} > > That's okay, but I think we should say something about the structure > of those strings, and {"variable": "value"} goes a long way towards ^^^^^^^ That should have been "objects", sorry. > that.