Re: [PATCH 10/11] Add global_context parameter to gdb.parse_and_eval

[Eli Zaretskii <eliz@gnu.org>]

> Date: Thu, 04 May 2023 08:21:31 -0600
> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
> 
> This adds a 'global_context' parse_and_eval to gdb.parse_and_eval.
> This lets users request a parse that is done at "global scope".
> 
> I considered letting callers pass in a block instead, with None
> meaning "global" -- but then there didn't seem to be a clean way to
> express the default for this parameter.
> ---
>  gdb/NEWS                              |  4 ++++
>  gdb/doc/python.texi                   |  7 ++++++-
>  gdb/python/python.c                   | 28 ++++++++++++++++++++++------
>  gdb/testsuite/gdb.python/py-value.c   |  3 +++
>  gdb/testsuite/gdb.python/py-value.exp |  5 +++++
>  5 files changed, 40 insertions(+), 7 deletions(-)

Thanks.

> diff --git a/gdb/NEWS b/gdb/NEWS
> index e3c095de09e..4bf5603b550 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -162,6 +162,10 @@ info main
>       (program-counter) values, and can be used as the frame-id when
>       calling gdb.PendingFrame.create_unwind_info.
>  
> +  ** gdb.parse_and_eval now has a new "global_context" parameter.
> +     This can be used to request that the parse only examine global
> +     symbols.
> +

This part is OK.

> --- a/gdb/doc/python.texi
> +++ b/gdb/doc/python.texi
> @@ -419,11 +419,16 @@ using the @code{gdb.Value} constructor.
>  @end defun
>  
>  @findex gdb.parse_and_eval
> -@defun gdb.parse_and_eval (expression)
> +@defun gdb.parse_and_eval (expression, @r{[}, global_context@r{]})
                                        ^
That comma is redundant, right?

Reviewed-By: Eli Zaretskii <eliz@gnu.org>