From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 63F493854153 for ; Thu, 23 Feb 2023 11:12:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 63F493854153 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pV9WF-0002QV-F8; Thu, 23 Feb 2023 06:12:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Da/9Ol9EmmDdXRLxDsjeIX9EeZbpfOolXT7j6mckBNg=; b=hGmaGdtz7f4x P/Ut/JamjQZaZxCtz+88YgG6P7b0whtHjWH7fgoXF2ATeErQCfpqspZyT2T/LiW1iBAwz9E1A4lDP lS0JvKkRndkVNzieCnrvU7po5lhjL+Je5uVHYF5UfdvzcHSdNOef4MSSneEVtw7/X4jtkPMdhfPAL Jlp0lh46aWI0O1qp5l+KGCNgjZ+KBn/f8AqrTsWfQk1gpRqP1U1wSS8YK6JkP7mAI84i4aY+p8rHG DuTTWK0Bnf8Jqcq4UBenIyQmoInEQ3lAIgID5AjKD5dNr8jm7xvu3Ok+412bn1/lATMQwRaulDdf0 LyjPOBVupfF3DC1ESPpdOQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pV9WE-00036C-Sv; Thu, 23 Feb 2023 06:12:11 -0500 Date: Thu, 23 Feb 2023 13:12:08 +0200 Message-Id: <834jrcr5yv.fsf@gnu.org> From: Eli Zaretskii To: Luis Machado Cc: gdb-patches@sourceware.org In-Reply-To: <20230223095230.1813266-1-luis.machado@arm.com> (message from Luis Machado on Thu, 23 Feb 2023 09:52:30 +0000) Subject: Re: [PATCH] [gdb/doc] arm: Expand documentation of XML features References: <20230223095230.1813266-1-luis.machado@arm.com> X-Spam-Status: No, score=1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Luis Machado > CC: > Date: Thu, 23 Feb 2023 09:52:30 +0000 > > The documentation of the XML features for Arm targets is very brief. I have > received feedback saying it is quite unclear from the perspective of the > debugging servers what should be defined in the XML features, how and > what the outcome is in gdb. > > This patch attempts to clarify a bit more what all the possible features are. Thanks. > +ARM targets. It must contain the following registers: > + > +@itemize @minus > +@item > +@samp{r0} through @samp{r12}. They are 32-bit in size and of type > +@samp{uint32}. Same comment here as in the previous patch: please say that these are registers. > +The description below is for historical purposes only. This feature > +used to contain the following registers: ^^ Two spaces. > +@samp{fps}, the status register. It has a size of 32-bit. ^^^^^^ Please lose the dash. I'd say "size of 32 bits." instead. Reviewed-By: Eli Zaretskii