From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv2 5/6] gdb: add inferior-specific breakpoints and watchpoints
Date: Fri, 20 Jan 2023 15:25:42 +0200 [thread overview]
Message-ID: <834jslnxrd.fsf@gnu.org> (raw)
In-Reply-To: <050da90b0b8c886983ec472a957b1075d4ecf7d6.1674207665.git.aburgess@redhat.com> (message from Andrew Burgess via Gdb-patches on Fri, 20 Jan 2023 09:46:28 +0000)
> Cc: Andrew Burgess <aburgess@redhat.com>
> Date: Fri, 20 Jan 2023 09:46:28 +0000
> From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
>
> This commit extends the breakpoint mechanism to allow for inferior
> specific breakpoints (and watchpoints).
>
> As GDB gains better support for multiple connections, and so for
> running multiple (possibly unrelated) inferiors, then it is not hard
> to imagine that a user might wish to create breakpoints that apply to
> any thread in a single inferior. To achieve this currently, the user
> would need to create a condition possibly making use of the $_inferior
> convenience variable, which, though functional, isn't the most user
> friendly.
>
> This commit adds a new 'inferior' keyword that allows for the creation
> of inferior specific breakpoints.
>
> Like thread specific breakpoints, the inferior specific breakpoints
> are automatically deleted once the inferior in question exits.
> ---
> gdb/NEWS | 7 +
> gdb/breakpoint.c | 171 +++++++++++++---
> gdb/breakpoint.h | 10 +-
> gdb/doc/gdb.texinfo | 74 ++++++-
> gdb/doc/python.texi | 24 ++-
> gdb/dummy-frame.c | 1 +
> gdb/elfread.c | 5 +-
> gdb/guile/scm-breakpoint.c | 5 +
> gdb/inferior.h | 11 ++
> gdb/infrun.c | 2 +
> gdb/linespec.c | 4 +-
> gdb/python/py-breakpoint.c | 77 ++++++++
> gdb/testsuite/gdb.linespec/cpcompletion.exp | 4 +-
> gdb/testsuite/gdb.linespec/explicit.exp | 1 +
> .../gdb.multi/inferior-specific-bp-1.c | 52 +++++
> .../gdb.multi/inferior-specific-bp-2.c | 52 +++++
> .../gdb.multi/inferior-specific-bp.exp | 182 ++++++++++++++++++
> gdb/testsuite/gdb.python/py-breakpoint.exp | 43 +++++
> gdb/testsuite/lib/completion-support.exp | 2 +-
> 19 files changed, 680 insertions(+), 47 deletions(-)
> create mode 100644 gdb/testsuite/gdb.multi/inferior-specific-bp-1.c
> create mode 100644 gdb/testsuite/gdb.multi/inferior-specific-bp-2.c
> create mode 100644 gdb/testsuite/gdb.multi/inferior-specific-bp.exp
Thanks, the documentation parts are OK.
next prev parent reply other threads:[~2023-01-20 13:25 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 11:25 [PATCH 0/6] Inferior specific breakpoints Andrew Burgess
2022-11-28 11:25 ` [PATCH 1/6] gdb/remote: announce thread exit events for remote targets Andrew Burgess
2022-11-28 11:25 ` [PATCH 2/6] gdb/testsuite: don't try to set non-stop mode on a running target Andrew Burgess
2022-11-28 11:25 ` [PATCH 3/6] gdb: fix display of thread condition for multi-location breakpoints Andrew Burgess
2022-12-23 8:37 ` Aktemur, Tankut Baris
2022-11-28 11:25 ` [PATCH 4/6] gdb: error if 'thread' or 'task' keywords are overused Andrew Burgess
2022-11-28 13:10 ` Eli Zaretskii
2022-11-28 11:25 ` [PATCH 5/6] gdb: add inferior-specific breakpoints and watchpoints Andrew Burgess
2022-11-28 13:18 ` Eli Zaretskii
2022-12-23 10:05 ` Aktemur, Tankut Baris
2023-01-19 19:13 ` Andrew Burgess
2023-01-20 13:12 ` Aktemur, Tankut Baris
2022-11-28 11:25 ` [PATCH 6/6] gdb: convert the 'start' breakpoint to use inferior keyword Andrew Burgess
2022-12-23 10:17 ` Aktemur, Tankut Baris
2022-12-23 10:55 ` [PATCH 0/6] Inferior specific breakpoints Aktemur, Tankut Baris
2023-01-20 9:46 ` [PATCHv2 " Andrew Burgess
2023-01-20 9:46 ` [PATCHv2 1/6] gdb/remote: announce thread exit events for remote targets Andrew Burgess
2023-02-02 17:50 ` Pedro Alves
2023-02-04 15:46 ` Andrew Burgess
2023-01-20 9:46 ` [PATCHv2 2/6] gdb/testsuite: don't try to set non-stop mode on a running target Andrew Burgess
2023-02-04 16:22 ` Andrew Burgess
2023-01-20 9:46 ` [PATCHv2 3/6] gdb: fix display of thread condition for multi-location breakpoints Andrew Burgess
2023-02-02 18:13 ` Pedro Alves
2023-02-06 14:48 ` Andrew Burgess
2023-02-06 17:01 ` Pedro Alves
2023-02-07 14:42 ` Andrew Burgess
2023-01-20 9:46 ` [PATCHv2 4/6] gdb: error if 'thread' or 'task' keywords are overused Andrew Burgess
2023-01-20 13:22 ` Eli Zaretskii
2023-02-02 14:08 ` Andrew Burgess
2023-02-02 14:31 ` Eli Zaretskii
2023-02-02 18:21 ` Pedro Alves
2023-02-03 16:41 ` Andrew Burgess
2023-02-04 5:52 ` Joel Brobecker
2023-02-04 15:40 ` Andrew Burgess
2023-02-06 11:06 ` Andrew Burgess
2023-01-20 9:46 ` [PATCHv2 5/6] gdb: add inferior-specific breakpoints and watchpoints Andrew Burgess
2023-01-20 13:25 ` Eli Zaretskii [this message]
2023-02-02 19:17 ` Pedro Alves
2023-02-03 16:55 ` Andrew Burgess
2023-02-06 17:24 ` Pedro Alves
2023-02-16 12:56 ` Aktemur, Tankut Baris
2023-01-20 9:46 ` [PATCHv2 6/6] gdb: convert the 'start' breakpoint to use inferior keyword Andrew Burgess
2023-02-16 12:59 ` Aktemur, Tankut Baris
2023-03-16 17:03 ` [PATCHv3 0/2] Inferior specific breakpoints Andrew Burgess
2023-03-16 17:03 ` [PATCHv3 1/2] gdb: cleanup around some set_momentary_breakpoint_at_pc calls Andrew Burgess
2023-04-03 14:12 ` Andrew Burgess
2023-03-16 17:03 ` [PATCHv3 2/2] gdb: add inferior-specific breakpoints Andrew Burgess
2023-04-03 14:14 ` [PATCHv4] " Andrew Burgess
2023-05-15 19:15 ` [PATCHv5] " Andrew Burgess
2023-05-30 20:41 ` [PATCHv6] " Andrew Burgess
2023-07-07 10:23 ` [PATCHv7] " Andrew Burgess
2023-08-17 15:53 ` [PUSHEDv8] " Andrew Burgess
2023-08-23 8:06 ` [PUSHED] gdb: add missing notify_breakpoint_modified call Andrew Burgess
2023-08-23 8:19 ` [PUSHED] gdb/testsuite: improve MI support for inferior specific breakpoints Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834jslnxrd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).