From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 26E5A3952491
 for <gdb-patches@sourceware.org>; Fri,  6 May 2022 12:25:26 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 26E5A3952491
Received: from fencepost.gnu.org ([2001:470:142:3::e]:44096)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nmx1R-0006aD-Gi; Fri, 06 May 2022 08:25:25 -0400
Received: from [87.69.77.57] (port=2409 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nmx1G-0004XT-0v; Fri, 06 May 2022 08:25:23 -0400
Date: Fri, 06 May 2022 15:25:02 +0300
Message-Id: <834k2226ht.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Felix Willgerodt <felix.willgerodt@intel.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20220506121226.137608-3-felix.willgerodt@intel.com> (message
 from Felix Willgerodt via Gdb-patches on Fri, 6 May 2022 14:12:24
 +0200)
Subject: Re: [PATCH 2/4] gdb, gdbserver: Add AMX registers.
References: <20220506121226.137608-1-felix.willgerodt@intel.com>
 <20220506121226.137608-3-felix.willgerodt@intel.com>
X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 06 May 2022 12:25:27 -0000

> Date: Fri,  6 May 2022 14:12:24 +0200
> From: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
> 
> +@subsubsection Intel @dfn{Advanced Matrix Extensions} (AMX).
> +@cindex Advanced Matrix Extensions (AMX).

Please make @cindex entries start with a lower-case letter.
Otherwise, the index could be sorted differently in different locales.

> +Advanced Matrix Extensions (AMX) adds one 64 byte @samp{TILECFG} register and
                               ^^^
Please use @acronym{AMX} there.

> +eight 1024 byte tile registers @samp{TMM0}, @samp{TMM1}, ..., @samp{TMM7}.
                                                            ^^^
This should be @dots{}, not 3 literal period characters.  The former
will look better in print (and even the Info manual).

> +@smallexample
> +	(gdb) print/x $tilecfg_raw
> +	$1 = 0x203020000000000000000000000000000000000000000000000000000001000
> +	10000c00000000000000000000000000000001
> +	(gdb) print $tilecfg
> +	$2 = @{palette = 0x1, start_row = 0x0, tile0.colsb = 0xc,
> +	tile1.colsb = 0x10, tile2.colsb = 0x10, tile3.colsb = 0x0,
> +	tile4.colsb = 0x0, tile5.colsb = 0x0, tile6.colsb = 0x0,
> +	tile7.colsb = 0x0, tile0.rows = 0x2, tile1.rows = 0x3, tile2.rows = 0x2,
> +	tile3.rows = 0x0, tile4.rows = 0x0, tile5.rows = 0x0, tile6.rows = 0x0,
> +	tile7.rows = 0x0@}
> +	(gdb) p $tmm0.m_int8
> +	$3 = @{@{0, 0, 0, 0, 1, 1, 1, 1, 2, 2, 2, 2@},	@{1, 1, 1, 1, 2, 2, 2,
> +	2, 3, 3, 3, 3@}@}
> +@end smallexample

Please avoid such long lines.  TeX cannot break lines in @example, so
we need to do that manually.

The documentation part is OK with the above fixed.

Thanks.