From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 90F443858407
 for <gdb-patches@sourceware.org>; Sat, 23 Apr 2022 09:22:30 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 90F443858407
Received: from fencepost.gnu.org ([2001:470:142:3::e]:57650)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1niByH-0007lY-Kl; Sat, 23 Apr 2022 05:22:29 -0400
Received: from [87.69.77.57] (port=4810 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1niByH-0006b1-42; Sat, 23 Apr 2022 05:22:29 -0400
Date: Sat, 23 Apr 2022 12:22:30 +0300
Message-Id: <834k2kp31l.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Enze Li <lienze2010@hotmail.com>
Cc: pedro@palves.net, tom@tromey.com, gdb-patches@sourceware.org
In-Reply-To: <MEAP282MB029360DCAA1C52684807348EDDF69@MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM>
 (message from Enze Li via Gdb-patches on Sat, 23 Apr 2022 17:16:55
 +0800)
Subject: Re: [PATCH v8 3/3] gdb/python: Export nibbles to python layer
References: <MEAP282MB0293F859A4DA5B33CB9096A0DDF69@MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM>
 <MEAP282MB029360DCAA1C52684807348EDDF69@MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM>
X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Apr 2022 09:22:31 -0000

> Date: Sat, 23 Apr 2022 17:16:55 +0800
> From: Enze Li via Gdb-patches <gdb-patches@sourceware.org>
> Cc: gdb-patches@sourceware.org
> 
> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
> index cb5283e03c0..5fd757d4891 100644
> --- a/gdb/doc/python.texi
> +++ b/gdb/doc/python.texi
> @@ -1094,6 +1094,11 @@ union} in @ref{Print Settings}).
>  address, @code{False} if it shouldn't (see @code{set print address} in
>  @ref{Print Settings}).
>  
> +@item nibbles
> +@code{True} if binary values should be displayed in groups of four bits,
> +known as nibbles. @code{False} if it shouldn't (see @code{set print
> +nibbles} in @ref{Print Settings}).

The part in parentheses will produce better output if you use @pxref:

  @code{False} if it shouldn't (@pxref{Print Settings, set print nibbles}).

Also, please leave two spaces between sentences, not one.

OK with these nits fixed.

Thanks.