From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id D581C3858D35
 for <gdb-patches@sourceware.org>; Mon,  3 Aug 2020 14:52:28 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D581C3858D35
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eliz@gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e]:43233)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1k2bpD-0007Wc-Tm; Mon, 03 Aug 2020 10:52:27 -0400
Received: from [176.228.60.248] (port=4298 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1k2bpD-0007nX-4O; Mon, 03 Aug 2020 10:52:27 -0400
Date: Mon, 03 Aug 2020 17:52:13 +0300
Message-Id: <834kpjbx42.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: "Jose E. Marchesi" <jose.marchesi@oracle.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20200803140237.14476-2-jose.marchesi@oracle.com>
 (gdb-patches@sourceware.org)
Subject: Re: [PATCH V6 1/3] gdb: support for eBPF
References: <20200803140237.14476-1-jose.marchesi@oracle.com>
 <20200803140237.14476-2-jose.marchesi@oracle.com>
X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Aug 2020 14:52:30 -0000

> Date: Mon,  3 Aug 2020 16:02:35 +0200
> From: "Jose E. Marchesi via Gdb-patches" <gdb-patches@sourceware.org>
> 
> This patch adds basic support for the eBPF target: tdep and build
> machinery.  The accompanying simulator is introduced in subsequent
> patches.
> 
> gdb/ChangeLog:
> 
> 2020-08-03  Weimin Pan <weimin.pan@oracle.com>
> 	    Jose E. Marchesi  <jose.marchesi@oracle.com>
> 
> 	* configure.tgt: Add entry for bpf-*-*.
> 	* Makefile.in (ALL_TARGET_OBS): Add bpf-tdep.o
> 	(ALLDEPFILES): Add bpf-tdep.c.
> 	* bpf-tdep.c: New file.
> 	* MAINTAINERS: Add bpf target and maintainer.
> 
> gdb/doc/ChangeLog:
> 
> 2020-08-03  Jose E. Marchesi  <jose.marchesi@oracle.com>
> 
> 	* gdb.texinfo (Contributors): Add information for the eBPF
> 	support.
> 	(BPF): New section.

Thanks.

> @@ -24381,6 +24385,7 @@ acceptable commands.
>  @menu
>  * ARC::                         Synopsys ARC
>  * ARM::                         ARM
> +* BPF::				eBPF
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Please don't use TABs in Texinfo sources.

Also, I think this should be called out in NEWS.

The documentation part is OK with these nits fixed.