From: Eli Zaretskii <eliz@gnu.org>
To: Heiher <r@hev.cc>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix read and access watchpoint can't stop
Date: Wed, 17 Jun 2020 19:38:35 +0300 [thread overview]
Message-ID: <834kr91wc4.fsf@gnu.org> (raw)
In-Reply-To: <20200617161708.15710-1-r@hev.cc> (message from Heiher on Thu, 18 Jun 2020 00:17:08 +0800)
> From: Heiher <r@hev.cc>
> Date: Thu, 18 Jun 2020 00:17:08 +0800
> Cc: Heiher <r@hev.cc>
>
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -4952,7 +4952,7 @@ bpstat_check_watchpoint (bpstat bs)
> this watchpoint. */
> must_check_value = 1;
> else if (b->watchpoint_triggered == watch_triggered_unknown
> - && b->type == bp_hardware_watchpoint)
> + && is_hardware_watchpoint (bs->breakpoint_at))
> /* We were stopped by a hardware watchpoint, but the target could
> not report the data address. We must check the watchpoint's
> value. Access and read watchpoints are out of luck; without
The comment below the line you suggest to modify explains why we don't
handle access and read watchpoints here. So I don't understand the
rationale for this change (it might be a good idea to explain it in
more detail in the log message). What am I missing?
Thanks.
next prev parent reply other threads:[~2020-06-17 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 16:17 Heiher
2020-06-17 16:38 ` Eli Zaretskii [this message]
2020-06-18 2:05 ` Hev
2020-06-18 13:35 ` Eli Zaretskii
2020-06-18 15:35 ` Hev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834kr91wc4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=r@hev.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).