From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id DAF8B386F836
 for <gdb-patches@sourceware.org>; Wed, 17 Jun 2020 16:38:51 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DAF8B386F836
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eliz@gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e]:47774)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1jlb5P-0004dc-B7; Wed, 17 Jun 2020 12:38:51 -0400
Received: from [176.228.60.248] (port=1586 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jlb5O-0003by-P4; Wed, 17 Jun 2020 12:38:51 -0400
Date: Wed, 17 Jun 2020 19:38:35 +0300
Message-Id: <834kr91wc4.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Heiher <r@hev.cc>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20200617161708.15710-1-r@hev.cc> (message from Heiher on Thu, 18
 Jun 2020 00:17:08 +0800)
Subject: Re: [PATCH] Fix read and access watchpoint can't stop
References: <20200617161708.15710-1-r@hev.cc>
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jun 2020 16:38:52 -0000

> From: Heiher <r@hev.cc>
> Date: Thu, 18 Jun 2020 00:17:08 +0800
> Cc: Heiher <r@hev.cc>
> 
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -4952,7 +4952,7 @@ bpstat_check_watchpoint (bpstat bs)
>  	   this watchpoint.  */
>  	must_check_value = 1;
>        else if (b->watchpoint_triggered == watch_triggered_unknown
> -	       && b->type == bp_hardware_watchpoint)
> +	       && is_hardware_watchpoint (bs->breakpoint_at))
>  	/* We were stopped by a hardware watchpoint, but the target could
>  	   not report the data address.  We must check the watchpoint's
>  	   value.  Access and read watchpoints are out of luck; without

The comment below the line you suggest to modify explains why we don't
handle access and read watchpoints here.  So I don't understand the
rationale for this change (it might be a good idea to explain it in
more detail in the log message).  What am I missing?

Thanks.