From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128556 invoked by alias); 4 Jan 2020 18:47:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128216 invoked by uid 89); 4 Jan 2020 18:47:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 04 Jan 2020 18:47:26 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54452) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1inoSL-0004Zq-60; Sat, 04 Jan 2020 13:47:25 -0500 Received: from [176.228.60.248] (port=2752 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1inoSK-0000wv-3t; Sat, 04 Jan 2020 13:47:24 -0500 Date: Sat, 04 Jan 2020 18:47:00 -0000 Message-Id: <834kxbgith.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: gdb-patches@sourceware.org In-reply-to: <20200104183410.17114-12-tom@tromey.com> (message from Tom Tromey on Sat, 4 Jan 2020 11:33:57 -0700) Subject: Re: [PATCH 11/24] Add horizontal splitting to TUI layout References: <20200104183410.17114-1-tom@tromey.com> <20200104183410.17114-12-tom@tromey.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00080.txt.bz2 > From: Tom Tromey > Cc: Tom Tromey > Date: Sat, 4 Jan 2020 11:33:57 -0700 > > gdb/ChangeLog > 2020-01-04 Tom Tromey > > PR tui/17850: > * tui/tui-win.c (tui_gen_win_info::max_width): New method. > * tui/tui-layout.h (class tui_layout_base) : Add > "height" argument. > (class tui_layout_window) : Likewise. > (class tui_layout_split) : Add "vertical" > argument. > : Add "height" argument. > : New field. > * tui/tui-layout.c (tui_layout_split::clone): Update. > (tui_layout_split::get_sizes): Add "height" argument. > (tui_layout_split::adjust_size, tui_layout_split::apply): Update. > (tui_new_layout_command): Parse "-horizontal". > (_initialize_tui_layout): Update help string. > (tui_layout_split::specification): Add "-horizontal" when needed. > * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height" > argument. > * tui/tui-data.h (struct tui_gen_win_info) : > New methods. > > gdb/doc/ChangeLog > 2020-01-04 Tom Tromey > > PR tui/17850: > * gdb.texinfo (TUI Commands): Document horizontal layouts. > > gdb/testsuite/ChangeLog > 2020-01-04 Tom Tromey > > PR tui/17850: > * gdb.tui/new-layout.exp: Add horizontal layout and winheight > tests. Thanks, the documentation parts are OK.