From: Eli Zaretskii <eliz@gnu.org>
To: gdb-patches@sourceware.org
Subject: Re: Compilation warning in simple-object-xcoff.c
Date: Sun, 21 Jan 2018 15:45:00 -0000 [thread overview]
Message-ID: <834lnfrzae.fsf@gnu.org> (raw)
In-Reply-To: <CAKOQZ8yQPkCw7AqaNp60Yg354MT7YT5fBeRutjqeC5x=PUrL-Q@mail.gmail.com> (message from Ian Lance Taylor on Sat, 20 Jan 2018 21:01:09 -0800)
> From: Ian Lance Taylor <iant@google.com>
> Date: Sat, 20 Jan 2018 21:01:09 -0800
> Cc: DJ Delorie <dj@redhat.com>, gcc-patches <gcc-patches@gcc.gnu.org>,
> gdb-patches <gdb-patches@sourceware.org>
>
> On Sat, Jan 20, 2018 at 4:47 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> >> Date: Thu, 18 Jan 2018 05:25:20 +0200
> >> From: Eli Zaretskii <eliz@gnu.org>
> >> CC: schwab@linux-m68k.org, gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org
> >>
> >> > From: DJ Delorie <dj@redhat.com>
> >> > Cc: schwab@linux-m68k.org, gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org
> >> > Date: Wed, 17 Jan 2018 15:47:49 -0500
> >> >
> >> > Eli Zaretskii <eliz@gnu.org> writes:
> >> >
> >> > > DJ, would the following semi-kludgey workaround be acceptable?
> >> >
> >> > It would be no worse than what we have now, if the only purpose is to
> >> > avoid a warning.
> >> >
> >> > Ideally, we would check to see if we're discarding non-zero values from
> >> > that offset, and not call the callback with known bogus data. I suppose
> >> > the usefulness of that depends on how often you'll encounter 4Gb+ xcoff64
> >> > files on mingw32 ?
> >>
> >> The answer to that question is "never", AFAIU.
> >
> > So can the patch I proposed be applied, please?
>
> I committed the patch.
So now that this patch is committed to upstream libiberty, is it OK to
push it to GDB's copy of the library?
next prev parent reply other threads:[~2018-01-21 15:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 17:45 Eli Zaretskii
2018-01-16 18:01 ` DJ Delorie
2018-01-16 18:25 ` Eli Zaretskii
2018-01-16 18:38 ` DJ Delorie
2018-01-16 22:01 ` Andreas Schwab
2018-01-17 15:21 ` Eli Zaretskii
2018-01-17 20:48 ` DJ Delorie
2018-01-18 3:25 ` Eli Zaretskii
2018-01-20 12:48 ` Eli Zaretskii
2018-01-21 5:01 ` Ian Lance Taylor via gdb-patches
2018-01-21 15:45 ` Eli Zaretskii
2018-01-21 15:45 ` Eli Zaretskii [this message]
2018-01-22 4:27 ` Joel Brobecker
2018-01-27 16:43 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834lnfrzae.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).