From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHSET] [2/4] Fix various issue in TUI
Date: Tue, 06 Jan 2015 15:58:00 -0000 [thread overview]
Message-ID: <834ms39a40.fsf@gnu.org> (raw)
In-Reply-To: <54AAE1D9.9000409@redhat.com>
> Date: Mon, 05 Jan 2015 19:11:21 +0000
> From: Pedro Alves <palves@redhat.com>
>
> > --- gdb/tui/tui-hooks.c~0 2014-06-11 18:34:41 +0300
> > +++ gdb/tui/tui-hooks.c 2014-12-31 14:41:11 +0200
> > @@ -247,12 +247,23 @@
> > tui_display_main ();
> > }
> >
> > +/* Refresh the display when settings important to us change. */
> > +static void
> > +tui_note_setting_change (const char *param, const char *value)
> > +{
> > + if (tui_active
> > + && strncmp (param, "tui ", sizeof ("tui ") - 1) == 0
> > + && tui_update_variables ())
> > + tui_rehighlight_all ();
> > +}
> > +
>
> Please do this from the "set" hook of the relevant commands instead.
> IOW, replace NULL below (and in the other commands):
>
> add_setshow_enum_cmd ("active-border-mode", no_class, tui_border_mode_enums,
> &tui_active_border_mode, _("\
> ...
> NULL,
> show_tui_active_border_mode,
> &tui_setlist, &tui_showlist);
Like this?
2015-01-06 Eli Zaretskii <eliz@gnu.org>
* tui/tui-win.c (tui_set_var_cmd): New function.
(_initialize_tui_win) <border-kind, border-mode>:
<active-border-mode>: Use tui_set_var_cmd as the "set" function.
--- gdb/tui/tui-win.c~2 2015-01-04 08:07:30 +0200
+++ gdb/tui/tui-win.c 2015-01-06 08:03:05 +0200
@@ -346,6 +346,12 @@ tui_get_cmd_list (void)
return &tuilist;
}
+void tui_set_var_cmd (char *null_args, int from_tty, struct cmd_list_element *c)
+{
+ if (tui_update_variables ())
+ tui_rehighlight_all ();
+}
+
/* Function to initialize gdb commands, for tui window
manipulation. */
@@ -422,7 +428,7 @@ This variable controls the border of TUI
space use a white space\n\
ascii use ascii characters + - | for the border\n\
acs use the Alternate Character Set"),
- NULL,
+ tui_set_var_cmd,
show_tui_border_kind,
&tui_setlist, &tui_showlist);
@@ -438,7 +444,7 @@ half use half bright\n\
half-standout use half bright and standout mode\n\
bold use extra bright or bold\n\
bold-standout use extra bright or bold with standout mode"),
- NULL,
+ tui_set_var_cmd,
show_tui_border_mode,
&tui_setlist, &tui_showlist);
@@ -454,7 +460,7 @@ half use half bright\n\
half-standout use half bright and standout mode\n\
bold use extra bright or bold\n\
bold-standout use extra bright or bold with standout mode"),
- NULL,
+ tui_set_var_cmd,
show_tui_active_border_mode,
&tui_setlist, &tui_showlist);
}
next prev parent reply other threads:[~2015-01-06 15:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-31 17:45 Eli Zaretskii
2015-01-05 19:11 ` Pedro Alves
2015-01-05 19:40 ` Eli Zaretskii
2015-01-06 16:03 ` Pedro Alves
2015-01-06 15:58 ` Eli Zaretskii [this message]
2015-01-07 13:48 ` Pedro Alves
2015-01-16 16:29 ` Eli Zaretskii
2015-01-16 16:59 ` Sergio Durigan Junior
2015-01-16 17:59 ` Eli Zaretskii
2015-01-16 16:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834ms39a40.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).