From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 205053858C56 for ; Fri, 19 Jan 2024 12:04:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 205053858C56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 205053858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705665896; cv=none; b=c9W6bNKHsCISbl9C9WA3s7+WUmEvQxJqahuXlG5mcaUNU/HFgDPu1Ohwdh8PuT0qrG4Nw3IBBvGdq7Y1E6qYL53AB2GlvxqyQcUFnUhmCUWZaekKbP8CCwt3ZQtx5Gwa8yzuTXIakmBUvcQOUC7Wg1o9uhTKfJfoWpAU4QBm780= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705665896; c=relaxed/simple; bh=0KRZcdU5qXsmHflC3da7MDSnntrZLZteiaNqMr3bn0M=; h=DKIM-Signature:Date:Message-Id:From:To:Subject:MIME-version; b=DOiOnda91Cok2MgX8v5nKy6t2lL/0KQjInh26Y+i6e6gtXX/hAtSfbskrPciyF/cIDVnrJyDaMRvWeDDJgpXXzWRuOmlOaV41Mrat7B6SyXTCkJ4klvnjVwR21/PlhcJvKlFNzHsrRojrv9G7vjXVdcGxIwiZFcP5ez2YOns9B0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQncD-0002GY-Aw; Fri, 19 Jan 2024 07:04:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=XlHgwXiIkNv3ZPZ3Cpk8tcLMeNRezo1GEp5eQ/YYSBM=; b=m0ORG1JAmjYN8IQ9dZ25 Ks8XER1kmbduR0DUkHP/G2yflAErYd+JJMfr6VoMFeiENerNoktBh136hZS2bWVy4ytc+Ui410NKl +QIe65bA0O9sTkn6rZuCDXtF683zmKVJqa16QHO37BTN4wmVE4wdElh3JaJ47ueklhQFsK+dkIQHP N/Ra3Wq//b1D4f8gwApJiKTsXHRFrC2aBA/bkyE7Jxpbr8vZsm0Ti8MMYnLM70ewPK575OPt1j1Yg BOwH9FNdYL11Gb70I6sa0YEUnWM3phxvsRqjoYVNfIzE+6yMjwi7QSZghlj3FUM/ZSCPnUYP6t3cw 3jhuRbeJ7QuTew==; Date: Fri, 19 Jan 2024 14:04:41 +0200 Message-Id: <835xzpwmue.fsf@gnu.org> From: Eli Zaretskii To: Alexandra =?utf-8?B?SMOhamtvdsOh?= Cc: gdb-patches@sourceware.org In-Reply-To: <20240119115659.491195-5-ahajkova@redhat.com> (message from Alexandra =?utf-8?B?SMOhamtvdsOh?= on Fri, 19 Jan 2024 12:56:27 +0100) Subject: Re: [PATCH v2 3/6] Add new vDefaultInferiorFd packet References: <20240119115659.491195-1-ahajkova@redhat.com> <20240119115659.491195-5-ahajkova@redhat.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Alexandra Hájková > Date: Fri, 19 Jan 2024 12:56:27 +0100 > > Add a new DefaultInferiorFd feature and the corresponding packet. > This feature allows GDB to send, to GDBserver, the file descriptor > numbers of the terminal to which GDB is connected. The inferior is > then started connected to the same terminal as GDB. This allows the > inferior run by local GDBserver to read from GDB's STDIN and write > its output to GDB's STOUT/ERR the same way as native target. > --- > gdb/doc/gdb.texinfo | 42 +++++++++++++ > gdb/remote.c | 28 +++++++++ > gdbserver/linux-low.cc | 6 ++ > gdbserver/linux-low.h | 2 + > gdbserver/server.cc | 135 ++++++++++++++++++++++++++++++++++++++++- > gdbserver/server.h | 12 ++++ > gdbserver/target.cc | 6 ++ > gdbserver/target.h | 6 ++ > 8 files changed, 234 insertions(+), 3 deletions(-) The documentation part of this is okay, thanks. Reviewed-By: Eli Zaretskii