Re: [PATCH v2 1/3] gdb, gdbserver, zpoint: report z_point support

[Eli Zaretskii <eliz@gnu.org>]

> From: Mohamed Bouhaouel <mohamed.bouhaouel@intel.com>
> Cc: blarsen@redhat.com,
> 	mohamed.bouhaouel@intel.com
> Date: Tue, 14 Nov 2023 10:20:27 +0100
> 
> Make gdbserver report which types of breakpoints and watchpoints
> are supported when exchanging features.  This is done by replying with
> Z<type>+ (Supported) or Z<type>- (unsupported)
> ---
>  gdb/NEWS               |  4 ++++
>  gdb/doc/gdb.texinfo    | 32 ++++++++++++++++++++++++++++++++
>  gdb/remote.c           | 16 ++++++++++++++++
>  gdbserver/mem-break.cc |  2 +-
>  gdbserver/mem-break.h  |  4 ++++
>  gdbserver/server.cc    |  7 +++++++
>  6 files changed, 64 insertions(+), 1 deletion(-)

Thanks.

> diff --git a/gdb/NEWS b/gdb/NEWS
> index 682def44ce0..8146f695df3 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -49,6 +49,10 @@ QThreadOptions in qSupported
>    QThreadOptions packet, and the qSupported response can contain the
>    set of thread options the remote stub supports.
>  
> +qSupported
> +  Gdbserver now reports which types of breakpoints and watchpoints
> +  are supported when exchanging features using Z<type>+, Z<type>-.
> +
>  *** Changes in GDB 14

This part is OK.

> +@item Z@var{type}
> +The remote stub reports which types of breakpoints and watchpoints are
> +supported.  This is done using flags, @samp{Z}@var{type}@samp{+} for supported
                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^
This should be @samp{Z@var{type}+}.  IOW, @var can be nested inside @samp.

> +and @samp{Z}@var{type}@samp{-} for unsupported, where @var{type} is one of
       ^^^^^^^^^^^^^^^^^^^^^^^^^^
Same here.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>