From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 6D70C3858D35 for ; Fri, 21 Jul 2023 11:04:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D70C3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMnwL-0007XS-GK; Fri, 21 Jul 2023 07:04:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CU+4iisaSB69i7qN4Jv3/KJUJlJ5V/ZiyJNTNGEimoU=; b=CgNTeWrNFM/X fa0ET1oZkjio1tTHWM4m3wtUBY+ewk64knV/Vk/qb6J81h5ubgSr2lReUVPPppJMkQtxR7Oa6YPtc rMGVEXe1y2wYiSIKiRf12ib6ndzQVKlBP7ttXG7WhXMC5uLFDVqi/2ejyVDgA0I4JY1g9ej85t9qP JclChmnQjWHHPDqB5wWcZPKNGgpT0FR5/eG6+NoPdbNiAN91T6TFudNI76OjjZen6BhPfIUDphiGw b/7+KtzxycxLISiwq/YuhsxG+XsFbYxtDuVn5iRFH/h7RwJbYBv0gMZQMlrKhzGEWHz7E1lsFXiGS U2C/ctjKslApcEc6g+uVzA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMnwG-0007c6-2i; Fri, 21 Jul 2023 07:04:52 -0400 Date: Fri, 21 Jul 2023 14:05:24 +0300 Message-Id: <835y6d1q4r.fsf@gnu.org> From: Eli Zaretskii To: Bruno Larsen Cc: gdb-patches@sourceware.org, pedro@palves.net In-Reply-To: <20230721102655.3486091-2-blarsen@redhat.com> (message from Bruno Larsen via Gdb-patches on Fri, 21 Jul 2023 12:26:56 +0200) Subject: Re: [PATCH v2] gdb/cli: fixes to newly added "list ." command References: <20230718112140.1911522-2-blarsen@redhat.com> <20230721102655.3486091-2-blarsen@redhat.com> X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: pedro@palves.net, > Bruno Larsen > Date: Fri, 21 Jul 2023 12:26:56 +0200 > From: Bruno Larsen via Gdb-patches > > After the series that added this command was pushed, Pedro mentioned > that the news description could easily be misinterpreted, as well as > some code and test improvements that should be made. > > While fixing the test, I realized that code repetition wasn't > happening as it should, so I took care of that too. > --- > Changes for v2: > * reworded documentation and help text Thanks. > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -87,8 +87,10 @@ > * The Ada 2022 Enum_Rep and Enum_Val attributes are now supported. > > * The 'list' command now accepts '.' as an argument, which tells GDB to > - print the location where the inferior is stopped. If the inferior hasn't > - started yet, the command will print around the main function. > + print the location around the default location. The default location ^^ Two spaces there, please. > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -9155,9 +9155,9 @@ Same as using with no arguments. > Print lines just before the lines last printed. > > @item list . > -Print the lines surrounding the location that is where the inferior > -is stopped. If the inferior is not running, print around the main > -function instead. > +Print the default location. The default location is where the inferior ^^ Likewise. Reviewed-By: Eli Zaretskii