From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 257F738582B0 for ; Tue, 18 Jul 2023 13:00:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 257F738582B0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([209.51.188.10]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLkJz-0002iU-GO; Tue, 18 Jul 2023 09:00:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dAGM5FWV6g5Nf2E/CQYicxrDi02yWWvSYTmMfJACFrs=; b=CIzcBBZxI3H6 N4gUa+t95xB0ZK3RDMDRbVZiYb5YC58PJBh3drvPIajtGFGD6K6+0JPpOfI+0sKe3WRzb9PNdCuJd OoP45AHG44g3gGQPDXokl/MTM30LD7MnPz4BQOBiGNIFFnUiL7nju/5YLj22WMp3ReXMfpHAuGAYC r9JGNCLpjfmR5Yl379Mg3iwV/+hdbeZx4TDtSUS2/u4vPIJFbmSLg+FR/vcHJ/7q4Bc95SyrJ/YHv SnSKLlvxlLT4eMkkQxS/cO71ebHPHXiHq5sVTwLx8QgcukbHLc6NHaMjSmj+NbrBqAqujUUWz3lhM q4GWmq5QJUyKlzLeNnr4Ag==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLkJz-0006vv-09; Tue, 18 Jul 2023 09:00:55 -0400 Date: Tue, 18 Jul 2023 16:01:24 +0300 Message-Id: <835y6h74rf.fsf@gnu.org> From: Eli Zaretskii To: Felix Willgerodt Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com, simark@simark.ca In-Reply-To: <20230718115637.3531-11-felix.willgerodt@intel.com> (message from Felix Willgerodt via Gdb-patches on Tue, 18 Jul 2023 13:56:37 +0200) Subject: Re: [PATCH v10 10/10] btrace: Extend ptwrite event decoding. References: <20230718115637.3531-1-felix.willgerodt@intel.com> <20230718115637.3531-11-felix.willgerodt@intel.com> X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Date: Tue, 18 Jul 2023 13:56:37 +0200 > From: Felix Willgerodt via Gdb-patches > > Call the ptwrite filter function whenever a ptwrite event is decoded. > The returned string is written to the aux_data string table and a > corresponding auxiliary instruction is appended to the function segment. > > Reviewed-By: Eli Zaretskii > --- > gdb/NEWS | 7 + > gdb/btrace.c | 58 +++ > gdb/config.in | 3 + > gdb/configure | 11 + > gdb/doc/python.texi | 149 ++++++ > gdb/testsuite/gdb.btrace/i386-ptwrite.S | 550 ++++++++++++++++++++++ > gdb/testsuite/gdb.btrace/ptwrite.c | 39 ++ > gdb/testsuite/gdb.btrace/ptwrite.exp | 202 ++++++++ > gdb/testsuite/gdb.btrace/x86_64-ptwrite.S | 544 +++++++++++++++++++++ > gdb/testsuite/lib/gdb.exp | 72 +++ > gdbsupport/common.m4 | 2 + > gdbsupport/config.in | 3 + > gdbsupport/configure | 11 + > 13 files changed, 1651 insertions(+) > create mode 100644 gdb/testsuite/gdb.btrace/i386-ptwrite.S > create mode 100644 gdb/testsuite/gdb.btrace/ptwrite.c > create mode 100644 gdb/testsuite/gdb.btrace/ptwrite.exp > create mode 100644 gdb/testsuite/gdb.btrace/x86_64-ptwrite.S The NEWS part is OK (the rest hasn't changed since v9, AFAIU). Thanks. Reviewed-By: Eli Zaretskii