From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Q5cO=BF=gnu.org=eliz@sourceware.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
	by sourceware.org (Postfix) with ESMTPS id 4CA6F3856DF6
	for <gdb-patches@sourceware.org>; Tue, 16 May 2023 19:10:47 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4CA6F3856DF6
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e])
	by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.90_1)
	(envelope-from <eliz@gnu.org>)
	id 1pz04M-0003RL-T0; Tue, 16 May 2023 15:10:46 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
	s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
	mime-version; bh=L5PNwxYl+imcg9dH8lcK5vZ24s4WzXBGZhkkdDD4Teo=; b=Y4AFMgcF/aBQ
	0CpMspgzxe7aR87ZOullA/NJ/q2+aUQ/1UIMa6nIeqRygf2bUQjnfYwSPCstUg6c52D/AvaENWecQ
	pQB7zfK6arcSLVCM4c7V+CTzo1ZNATQU1VvsTHksFlL95ltVyr8mbTSrG+tzRESjVFpiYaYzbgdtY
	zNxCtwFVJ4LK894nBYTD6XEoXzft2fyB4iKDBzDXw+M8yOLv6yaQ5sceDfrK7ddJf+OpXUx6QgcIQ
	nFocv9zvglxRPukSf9w3sjPN06FDMmYxjXCZNxzNFDumXroeLErNjaYRyXkkPkgJpkAzypIrO2rs0
	/G6BqiiRA/EoVmW5h2Q4xw==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.90_1)
	(envelope-from <eliz@gnu.org>)
	id 1pz04M-00029d-Cc; Tue, 16 May 2023 15:10:46 -0400
Date: Tue, 16 May 2023 22:10:54 +0300
Message-Id: <835y8sytvl.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <87pm7014gu.fsf@tromey.com> (message from Tom Tromey on Tue, 16
	May 2023 13:06:09 -0600)
Subject: Re: [PATCH 2/2] Add "args" and "env" parameters to DAP launch request
References: <20230509-dap-args-v1-0-16b5f0aa5cd6@adacore.com>
	<20230509-dap-args-v1-2-16b5f0aa5cd6@adacore.com>
	<83zg6da3jp.fsf@gnu.org> <87pm7014gu.fsf@tromey.com>
X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

> From: Tom Tromey <tromey@adacore.com>
> Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
> Date: Tue, 16 May 2023 13:06:09 -0600
> 
> >> +@item env
> >> +If provided, this should be an object where each value is a string.
> 
> Eli> This doesn't say what should those string values be.  Shouldn't they
> Eli> be of the format "@var{variable}=@var{value}"?
> 
> In JSON an object is a dictionary; so the keys are strings and the
> values are as well.  That is it looks like {"variable": "value"}

That's okay, but I think we should say something about the structure
of those strings, and {"variable": "value"} goes a long way towards
that.