From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 0A7A53858D20 for ; Fri, 20 Jan 2023 13:23:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0A7A53858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIrMB-0002p8-GF; Fri, 20 Jan 2023 08:22:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VxNUPU2iuG8gA8Tixfs+bJOCLfwf/vc55DGTC4LO+cc=; b=AfHqs3JoMNHf m8iwX88E55AcTkZUUcdIrU/s56mMpmkjgNfG00j9WOxgDmTLQwvqz8O4g6spXJXKrjeNnsFq9UH7p meuDmQoVQZT1G0uORSwWotcx/4kzsYyjKnHS9tDH1Th75qz4k0jznZC+Tk6F93tFNubnGVrA/Xndz ketHmQVAQuzj3QbONYiBo7/w+Zfc74aM2AZwwv/3RFp/DNbvQ1fsmrlZvd4winLFh6Ndw1var/fft GtbFr7e3Mz0YO9iHITEg47Fny2iQBa/0K9Wu4M2DDGk0wNPJSBJEkNyUR+2ONacI6JS0zWikPfWOv u340o1a6t4Y2orPoY10RoA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIrMA-00044B-M3; Fri, 20 Jan 2023 08:22:59 -0500 Date: Fri, 20 Jan 2023 15:22:56 +0200 Message-Id: <835yd1nxvz.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess Cc: gdb-patches@sourceware.org In-Reply-To: (message from Andrew Burgess via Gdb-patches on Fri, 20 Jan 2023 09:46:27 +0000) Subject: Re: [PATCHv2 4/6] gdb: error if 'thread' or 'task' keywords are overused References: X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: Andrew Burgess > Date: Fri, 20 Jan 2023 09:46:27 +0000 > From: Andrew Burgess via Gdb-patches > > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -9,6 +9,15 @@ > This support requires that GDB be built with Python scripting > enabled. > > +* For the break command, multiple uses of the 'thread' or 'task' > + keywords will now give an error instead of just using the thread or > + task id from the last instance of the keyword. > + > +* For the watch command, multiple uses of the 'task' keyword will now > + give an error instead of just using the task id from the last > + instance of the keyword. The 'thread' keyword already gave an error > + when used multiple times with the watch command, this remains unchanged. This part is OK, but I wonder whether we should provide an example of such incorrect usage which will now be flagged, because I'm not sure everyone will understand what "multiple uses" means in this context. Thanks.