From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 790C63858D37; Fri, 13 Jan 2023 15:05:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 790C63858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGLcq-0005s8-Gj; Fri, 13 Jan 2023 10:05:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZPf7FsFxn96/G/3tHtpaNhnK3HfX7bzRcO+Fng8BECs=; b=dgTbQx5ss5S0 HNrg/n6/8BqlKAJa4qtOrZKXW+05NU0I1OSUcEMjOKaefbhdPJIPbnn8LwpnVoIVrBL6ip1bCmkpx zRAm6gf0WC9CXrCWlKTj9G0sg1LP2rzOadNS0fCjdhksS6ZoYaWfOQU230jEoHquN9yT3hvT81wT2 A9dO9GKNGKwP9wpwwHTNq0vFhbY8cPwwBG4NIoiKpegn4wqa2+zPyQw61E6/xalGmIoWzn7AYEHYO rQ2zzou5eDpyySmFZ2GIglF+RL8Zqni5LyKVRs/zgG1iMOhSaYaCeDsiC6RKpokYa1WJhcncyFXBm QCb8Gy1jymc8poYNsOOspw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGLcq-0001xY-01; Fri, 13 Jan 2023 10:05:48 -0500 Date: Fri, 13 Jan 2023 17:05:47 +0200 Message-Id: <835ydaa304.fsf@gnu.org> From: Eli Zaretskii To: Enze Li Cc: binutils@sourceware.org, gdb-patches@sourceware.org, enze.li@gmx.com In-Reply-To: (message from Enze Li via Gdb-patches on Fri, 13 Jan 2023 22:42:32 +0800) Subject: Re: [PATCH] libctf: update regexp to allow makeinfo to build document References: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: gdb-patches@sourceware.org, > enze.li@gmx.com > Date: Fri, 13 Jan 2023 22:42:32 +0800 > From: Enze Li via Gdb-patches > > While trying to build gdb on latest openSUSE Tumbleweed, I noticed the > following warning, > > checking for makeinfo... makeinfo --split-size=5000000 > configure: WARNING: > *** Makeinfo is too old. Info documentation will not be built. > > then I checked the version of makeinfo, it said, > ====== > $ makeinfo --version > texi2any (GNU texinfo) 7.0.1 > > Copyright (C) 2022 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. > ====== > > After digging a little bit, it became quite obvious that a dot is > missing in regexp that makes it impossible to match versions higher than > 7.0. Thanks. > libctf/ChangeLog: > > * configure: Regenerated. > * configure.ac: Update regexp to match versions higher than 7.0. > --- > libctf/configure | 2 +- > libctf/configure.ac | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libctf/configure b/libctf/configure > index c22f7dffd2c..e9f7125edea 100755 > --- a/libctf/configure > +++ b/libctf/configure > @@ -14864,7 +14864,7 @@ esac > # We require texinfo to be 6.3 or later, for a working synindex > # and validatemenus: otherwise we fall back to /bin/true. > if ${MAKEINFO} --version \ > - | egrep 'texinfo[^0-9]*(6\.[3-9]|[7-9][0-9])' >/dev/null 2>&1; then > + | egrep 'texinfo[^0-9]*(6\.[3-9]|[7-9]\.[0-9])' >/dev/null 2>&1; then > build_info=yes > else > build_info= > diff --git a/libctf/configure.ac b/libctf/configure.ac > index 1d0cf4d0fa5..4bc75736542 100644 > --- a/libctf/configure.ac > +++ b/libctf/configure.ac > @@ -184,7 +184,7 @@ changequote(,) > # We require texinfo to be 6.3 or later, for a working synindex > # and validatemenus: otherwise we fall back to /bin/true. > if ${MAKEINFO} --version \ > - | egrep 'texinfo[^0-9]*(6\.[3-9]|[7-9][0-9])' >/dev/null 2>&1; then > + | egrep 'texinfo[^0-9]*(6\.[3-9]|[7-9]\.[0-9])' >/dev/null 2>&1; then > build_info=yes > else > build_info= IMO, this solution has the same problem: it will stop working when Texinfo 10.1 will be released. I think the solution should be to use egrep 'texinfo[^0-9]*(6\.[3-9]|[7-9][0-9]?)' That is, we don't care about the minor version for Texinfo > 6.9, we only care about the major version.