From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 001C2396D810 for ; Fri, 16 Sep 2022 11:49:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 001C2396D810 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40922) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ9qJ-0005gL-KS; Fri, 16 Sep 2022 07:49:11 -0400 Received: from [87.69.77.57] (port=4339 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ9qJ-0006ek-3i; Fri, 16 Sep 2022 07:49:11 -0400 Date: Fri, 16 Sep 2022 14:49:05 +0300 Message-Id: <835yhn4k0e.fsf@gnu.org> From: Eli Zaretskii To: Felix Willgerodt Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com In-Reply-To: <20220916113646.49749-8-felix.willgerodt@intel.com> (message from Felix Willgerodt via Gdb-patches on Fri, 16 Sep 2022 13:36:43 +0200) Subject: Re: [PATCH v6 07/10] btrace, gdbserver: Add ptwrite to btrace_config_pt. References: <20220916113646.49749-1-felix.willgerodt@intel.com> <20220916113646.49749-8-felix.willgerodt@intel.com> X-Spam-Status: No, score=1.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2022 11:49:13 -0000 > Date: Fri, 16 Sep 2022 13:36:43 +0200 > From: Felix Willgerodt via Gdb-patches > > +@item Qbtrace-conf:pt:ptwrite=@var{(yes|no)} > +Indicate support for ptwrite packets. This allows for backwards- > +compatibility. I think "ptwrite" should be in @code, since it's a program symbol. Also, we leave hyphenation to TeX, so please don't break lines at the hyphen, as you did with "backwards-compatibility". > +Reply: > +@table @samp > +@item OK > +The ptwrite config parameter has been set. ^^^^^^^ @code{ptwrite} Thanks.