Re: [PATCH 7/9] gdb/doc: update syntax of -data-disassemble command arguments

[Eli Zaretskii <eliz@gnu.org>]

> Date: Thu, 23 Jun 2022 17:05:14 +0100
> From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Andrew Burgess <aburgess@redhat.com>
> 
> The argument documentation looks like this:
> 
>    -data-disassemble
>       [ -s @var{start-addr} -e @var{end-addr} ]
>     | [ -a @var{addr} ]
>     | [ -f @var{filename} -l @var{linenum} [ -n @var{lines} ] ]
>     -- @var{mode}
> 
> However, I believe, according to the 'Notation and Terminology'
> section, this means that the there are 3 optional location
> specification argument groups for the command, followed by a
> non-optional '-- mode'.
> 
> However, this is not true, one of the location specification must be
> given, i.e. we can't choose to give NO location specification, which
> is what the above implies.

I don't believe we ever used this convention this rigorously.  But I
agree that it is better to be as accurate as possible.

> I propose that we change this to instead be:
> 
>    -data-disassemble
>     ( -s @var{start-addr} -e @var{end-addr}
>     | -a @var{addr}
>     | -f @var{filename} -l @var{linenum} [ -n @var{lines} ] )
>     -- @var{mode}
> 
> By placing all the location specifications within '( ... )' we
> indication that these are a group, from which one of the options,
> separated by '|', must be selected.

According to "Notation and Terminology", the (...) construct should be
followed by either * or +, so I think you should use + here.

Otherwise, this is fine, thanks.