From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 89C0D385085F
 for <gdb-patches@sourceware.org>; Tue,  7 Jun 2022 16:10:33 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 89C0D385085F
Received: from fencepost.gnu.org ([2001:470:142:3::e]:39574)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nybmq-000562-VB; Tue, 07 Jun 2022 12:10:32 -0400
Received: from [87.69.77.57] (port=2731 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nybmf-00026y-Eo; Tue, 07 Jun 2022 12:10:32 -0400
Date: Tue, 07 Jun 2022 19:10:14 +0300
Message-Id: <835ylc78ux.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20220607154226.3281521-3-tromey@adacore.com> (message from Tom
 Tromey via Gdb-patches on Tue, 7 Jun 2022 09:42:26 -0600)
Subject: Re: [PATCH 2/2] Add 'summary' mode to Value.format_string
References: <20220607154226.3281521-1-tromey@adacore.com>
 <20220607154226.3281521-3-tromey@adacore.com>
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Jun 2022 16:10:34 -0000

> Date: Tue,  7 Jun 2022 09:42:26 -0600
> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Tom Tromey <tromey@adacore.com>
> 
> This adds a 'summary' mode to Value.format_string and to
> gdb.print_options.  For the former, it lets Python code format values
> using this mode.  For the latter, it lets a printer potentially detect
> if it is being called in a backtrace with 'set print frame-arguments'
> set to 'scalars'.

Thanks.

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -70,6 +70,8 @@ maintenance info line-table
>    ** gdb.Value.format_string now uses the format provided by 'print',
>       if it is called during a 'print' or other similar operation.
>  
> +  ** gdb.Value.format_string now accepts the 'summary' keyword.

Maybe say something about what this does?

The documentation parts are OK.