From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 675733857005
 for <gdb-patches@sourceware.org>; Sat, 26 Sep 2020 06:09:47 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 675733857005
Received: from fencepost.gnu.org ([2001:470:142:3::e]:56203)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1kM3P1-0005Le-0Y; Sat, 26 Sep 2020 02:09:47 -0400
Received: from [176.228.60.248] (port=1447 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1kM3Oz-0001jf-J9; Sat, 26 Sep 2020 02:09:46 -0400
Date: Sat, 26 Sep 2020 09:09:59 +0300
Message-Id: <835z81rruw.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <65f550256846e33e9c708f1d50878ee71d5d7ac4.1601070702.git.andrew.burgess@embecosm.com>
 (message from Andrew Burgess on Fri, 25 Sep 2020 23:24:08 +0100)
Subject: Re: [PATCHv3 2/3] gdb: Restore previously selected thread when
 switching inferior
References: <cover.1601070702.git.andrew.burgess@embecosm.com>
 <65f550256846e33e9c708f1d50878ee71d5d7ac4.1601070702.git.andrew.burgess@embecosm.com>
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Sep 2020 06:09:48 -0000

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Fri, 25 Sep 2020 23:24:08 +0100
> 
> This commit adds a new option that allows the user to control how GDB
> behaves when switching between multi-threaded inferiors.

Thanks.  Some commas are missing, see below.

> +set restore-selected-thread on|off
> +show restore-selected-thread
> +  This new option is off by default.

This sentence is redundant in NEWS, and IMO should be removed.

> +                                      When turned on GDB will record
                                                       ^
Please add a comma there.

> +  the currently selected thread in each inferior.  When switching
> +  between inferiors GDB will attempt to restore the previously
                      ^
And here.

> +  selected thread in the inferior being switched too.  If the
> +  previously selected thread is no longer available then GDB falls
                                                      ^
And there.

> +When switching between inferiors with multiple threads
> +(@pxref{Threads}) @value{GDBN} will select the first non-exited thread
                    ^
Likewise.

> +in the inferior being switched to and make this the current thread.
                                    ^
Same.

> +When this option is on @value{GDBN} will record the currently selected
                         ^
Here as well.

> +thread in each inferior.  When switching between inferior @value{GDBN}
                                                            ^
And here.  Also, I think you meant "between inferiors", plural.

> -Otherwise, only @var{thread-num} is shown.
> +Otherwise, only @var{thread-num} is shown.  When switching between
> +inferiors @value{GDBN} will select a suitable thread in the inferior
            ^
Please add a comma here.

> +being switched to, see @ref{inferior command,,the @code{inferior}
> +command} for further details on how to control this behaviour.
           ^
And here.

The documentation parts are okay with these fixed.