public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/doco] set varsize-limit: New GDB setting for maximum dynamic object size
Date: Fri, 23 Feb 2018 07:11:00 -0000	[thread overview]
Message-ID: <83606o5gfq.fsf@gnu.org> (raw)
In-Reply-To: <20180223045914.47lm5byba3o6xrqo@adacore.com> (message from Joel	Brobecker on Fri, 23 Feb 2018 08:59:14 +0400)

> Date: Fri, 23 Feb 2018 08:59:14 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
> 
> Sometimes, I wonder what we would do without your help!

Thanks.

> > > +  add_setshow_uinteger_cmd ("varsize-limit", class_support,
> > > +			    &varsize_limit, _("\
> > > +Set the maximum number of bytes allowed in a dynamic-sized object."), _("\
> > > +Show the maximum number of bytes allowed in a dynamic-sized object."), _("\
> > > +Attempts to access an object whose size is not a compile-time constant\n\
> > > +and exceeds this limit will cause an error."),
> > 
> > This is okay, but I wonder if "varsize" is a good name.  The
> > explanatory text you've written doesn't talk of any "variables".
> 
> It was before my time (so more than 15 years ago!), but I think that
> "var" (for variable) is the adjective, rather than the noun.

Then I suggest to use "variable-size objects" instead of
"dynamic-sized objects" in the doc string, and probably also in the
manual.

Otherwise, the new version of the patch is fine in the documentation
parts.

  reply	other threads:[~2018-02-23  7:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22 15:21 Joel Brobecker
2018-02-22 15:47 ` Eli Zaretskii
2018-02-23  4:59   ` Joel Brobecker
2018-02-23  7:11     ` Eli Zaretskii [this message]
2018-02-23 10:21       ` Joel Brobecker
2018-02-23 13:56         ` Eli Zaretskii
2018-03-27 14:23         ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83606o5gfq.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).