From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71973 invoked by alias); 23 Feb 2018 07:11:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71963 invoked by uid 89); 23 Feb 2018 07:11:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=talk X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Feb 2018 07:11:26 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ep7VI-00011b-Ex for gdb-patches@sourceware.org; Fri, 23 Feb 2018 02:11:24 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ep7VI-00011J-7F; Fri, 23 Feb 2018 02:10:48 -0500 Received: from [176.228.60.248] (port=3049 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ep7VH-0004EZ-EL; Fri, 23 Feb 2018 02:10:47 -0500 Date: Fri, 23 Feb 2018 07:11:00 -0000 Message-Id: <83606o5gfq.fsf@gnu.org> From: Eli Zaretskii To: Joel Brobecker CC: gdb-patches@sourceware.org In-reply-to: <20180223045914.47lm5byba3o6xrqo@adacore.com> (message from Joel Brobecker on Fri, 23 Feb 2018 08:59:14 +0400) Subject: Re: [RFA/doco] set varsize-limit: New GDB setting for maximum dynamic object size Reply-to: Eli Zaretskii References: <1519312873-6307-1-git-send-email-brobecker@adacore.com> <83efld58mu.fsf@gnu.org> <20180223045914.47lm5byba3o6xrqo@adacore.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00334.txt.bz2 > Date: Fri, 23 Feb 2018 08:59:14 +0400 > From: Joel Brobecker > Cc: gdb-patches@sourceware.org > > Sometimes, I wonder what we would do without your help! Thanks. > > > + add_setshow_uinteger_cmd ("varsize-limit", class_support, > > > + &varsize_limit, _("\ > > > +Set the maximum number of bytes allowed in a dynamic-sized object."), _("\ > > > +Show the maximum number of bytes allowed in a dynamic-sized object."), _("\ > > > +Attempts to access an object whose size is not a compile-time constant\n\ > > > +and exceeds this limit will cause an error."), > > > > This is okay, but I wonder if "varsize" is a good name. The > > explanatory text you've written doesn't talk of any "variables". > > It was before my time (so more than 15 years ago!), but I think that > "var" (for variable) is the adjective, rather than the noun. Then I suggest to use "variable-size objects" instead of "dynamic-sized objects" in the doc string, and probably also in the manual. Otherwise, the new version of the patch is fine in the documentation parts.