From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101659 invoked by alias); 27 Jan 2018 16:42:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101649 invoked by uid 89); 27 Jan 2018 16:42:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=gdb81branch, gdb-8.1-branch X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 27 Jan 2018 16:42:27 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1efTYc-0002a7-9s for gdb-patches@sourceware.org; Sat, 27 Jan 2018 11:42:26 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55897) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efTYc-0002Zx-6e; Sat, 27 Jan 2018 11:42:22 -0500 Received: from [176.228.60.248] (port=3524 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1efTYb-0007se-Ki; Sat, 27 Jan 2018 11:42:22 -0500 Date: Sat, 27 Jan 2018 16:42:00 -0000 Message-Id: <83607njlsh.fsf@gnu.org> From: Eli Zaretskii To: simon.marchi@ericsson.com CC: gdb-patches@sourceware.org In-reply-to: <838tcklaev.fsf@gnu.org> (message from Eli Zaretskii on Fri, 26 Jan 2018 20:52:56 +0200) Subject: Re: [ANNOUNCEMENT] GDB 8.1 release branch created! Reply-to: Eli Zaretskii References: <83h8rlyakm.fsf@gnu.org> <83lggvupt6.fsf@gnu.org> <83lgglnadl.fsf@gnu.org> <83fu6sln4o.fsf@gnu.org> <3d75778f-5c91-5680-b9fa-c2f2c902ff67@ericsson.com> <838tcklaev.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00570.txt.bz2 > Date: Fri, 26 Jan 2018 20:52:56 +0200 > From: Eli Zaretskii > CC: gdb-patches@sourceware.org > > > From: Simon Marchi > > Date: Fri, 26 Jan 2018 10:36:56 -0500 > > >>>> > > >>>> +/* Another kludge to avoid compilation errors because MinGW defines > > >>>> + 'hypot' to '_hypot', but the C++ headers says "using ::hypot". */ > > >>>> +#if defined(__MINGW32__) && defined(__cplusplus) > > > > Do we need "defined(__cplusplus)", since we are always building GDB as a C++ program? > > I'm okay with dropping it. No further comments, so I went ahead and pushed the change, without the __cplusplus part, to master, and then cherry-picked to gdb-8.1-branch. Thanks for the feedback, Simon.