public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Hannes Domani <ssbssa@yahoo.de>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	 Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH 2/2] Fix InlinedFrameDecorator example
Date: Sat, 29 May 2021 11:41:56 +0000 (UTC)	[thread overview]
Message-ID: <836117070.2130869.1622288516335@mail.yahoo.com> (raw)
In-Reply-To: <896618fc-de44-3405-204c-f02e4f9d1ab7@polymtl.ca>

 Am Samstag, 29. Mai 2021, 03:35:06 MESZ hat Simon Marchi <simon.marchi@polymtl.ca> Folgendes geschrieben:

> On 2021-05-26 1:15 p.m., Hannes Domani via Gdb-patches wrote:
> > Argument fobj was only available in the constructor.
> >
> > gdb/doc/ChangeLog:
> >
> > 2021-05-26  Hannes Domani  <ssbssa@yahoo.de>
> >
> >     * python.texi (Writing a Frame Filter): Fix example.
> > ---
> >  gdb/doc/python.texi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
> > index 4137e8ed796..0d8f480e472 100644
> > --- a/gdb/doc/python.texi
> > +++ b/gdb/doc/python.texi
> > @@ -2373,7 +2373,7 @@ class InlinedFrameDecorator(FrameDecorator):
> >          super(InlinedFrameDecorator, self).__init__(fobj)
> >
> >      def function(self):
> > -        frame = fobj.inferior_frame()
> > +        frame = self.inferior_frame()
> >          name = str(frame.name())
> >
> >          if frame.type() == gdb.INLINE_FRAME:
>
> >
>
>
> LGTM, thanks.

Pushed, thanks.


Hannes

  reply	other threads:[~2021-05-29 11:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210526171541.769-1-ssbssa.ref@yahoo.de>
2021-05-26 17:15 ` [PATCH 1/2] Document gdb.SYMBOL_LOC_LABEL Hannes Domani
2021-05-26 17:15   ` [PATCH 2/2] Fix InlinedFrameDecorator example Hannes Domani
2021-05-29  1:34     ` Simon Marchi
2021-05-29 11:41       ` Hannes Domani [this message]
2021-05-26 17:29   ` [PATCH 1/2] Document gdb.SYMBOL_LOC_LABEL Eli Zaretskii
2021-05-27 17:56     ` Hannes Domani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=836117070.2130869.1622288516335@mail.yahoo.com \
    --to=ssbssa@yahoo.de \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).