From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, dilyan.palauzov@aegee.org,
andrew.burgess@embecosm.com
Subject: Re: [PATCH] gdb/doc: Fix incorrect use of @xref.
Date: Mon, 06 Jul 2015 17:04:00 -0000 [thread overview]
Message-ID: <83615xw74r.fsf@gnu.org> (raw)
In-Reply-To: <e89c4fbf774e10c45cb0a16fe25f4d90539be22c.1436182798.git.andrew.burgess@embecosm.com>
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: Dilyan Palauzov <dilyan.palauzov@aegee.org>,
> Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Mon, 6 Jul 2015 12:45:33 +0100
>
> It has been pointed out to me that in commit a4ea0946c I introduced a
> use of @xref that is not followed by either a ',' or a '.' as it is
> supposed to be[1].
>
> Normally I would push such a trivial change as an obvious fix,
> however, I'm a little more nervous when it comes to documentation
> changes, so I'd like a review please.
Thanks. I suggest simply to add a comma after the xref's closing
brace. That's the schoolbook solution for these problems.
Sorry for not catching this during my review.
prev parent reply other threads:[~2015-07-06 17:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 11:46 Andrew Burgess
2015-07-06 17:04 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83615xw74r.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=andrew.burgess@embecosm.com \
--cc=dilyan.palauzov@aegee.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).